RE: [PATCH net-next 2/3] ptp: igb: Use the high resolution frequency method.

2016-11-09 Thread Keller, Jacob E
..@spectralink.com; > da...@davemloft.net; Kirsher, Jeffrey T ; > john.stu...@linaro.org; intel-wired-...@lists.osuosl.org > Subject: Re: [PATCH net-next 2/3] ptp: igb: Use the high resolution frequency > method. > > On Tue, Nov 08, 2016 at 10:02:22PM +, Keller, Jacob E wrote: &

Re: [PATCH net-next 2/3] ptp: igb: Use the high resolution frequency method.

2016-11-09 Thread Richard Cochran
On Tue, Nov 08, 2016 at 10:04:23PM +, Keller, Jacob E wrote: > Additionally, what about min/max frequency check? Wouldn't this need to > be updated for the new adjfine operation? In theory you might increase the max by some sub-ppb value, but we cannot express that as the resolution of the use

Re: [PATCH net-next 2/3] ptp: igb: Use the high resolution frequency method.

2016-11-09 Thread Richard Cochran
On Tue, Nov 08, 2016 at 10:02:22PM +, Keller, Jacob E wrote: > On Tue, 2016-11-08 at 22:49 +0100, Richard Cochran wrote: > > - rate = ppb; > > - rate <<= 26; > > - rate = div_u64(rate, 1953125); > > + rate = scaled_ppm; > > + rate <<= 13; > > + rate = div_u64(rate, 15625); > > I'm

Re: [PATCH net-next 2/3] ptp: igb: Use the high resolution frequency method.

2016-11-08 Thread Keller, Jacob E
On Tue, 2016-11-08 at 22:49 +0100, Richard Cochran wrote: > The 82580 and related devices offer a frequency resolution of about > 0.029 ppb.  This patch lets users of the device benefit from the > increased frequency resolution when tuning the clock. > > Signed-off-by: Richard Cochran > --- Addi

Re: [PATCH net-next 2/3] ptp: igb: Use the high resolution frequency method.

2016-11-08 Thread Keller, Jacob E
On Tue, 2016-11-08 at 22:49 +0100, Richard Cochran wrote: > The 82580 and related devices offer a frequency resolution of about > 0.029 ppb.  This patch lets users of the device benefit from the > increased frequency resolution when tuning the clock. > > Signed-off-by: Richard Cochran > --- >  dr

[PATCH net-next 2/3] ptp: igb: Use the high resolution frequency method.

2016-11-08 Thread Richard Cochran
The 82580 and related devices offer a frequency resolution of about 0.029 ppb. This patch lets users of the device benefit from the increased frequency resolution when tuning the clock. Signed-off-by: Richard Cochran --- drivers/net/ethernet/intel/igb/igb_ptp.c | 16 1 file cha