Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-20 Thread Pablo Neira Ayuso
On Tue, Apr 20, 2021 at 01:51:07PM +0200, Frank Wunderlich wrote: > Am 18. April 2021 23:11:44 MESZ schrieb Pablo Neira Ayuso > : > >Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy > >and > >stats to different workqueues") splits the workqueue per event type. > >Add > >a mutex

Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-20 Thread Frank Wunderlich
Am 18. April 2021 23:11:44 MESZ schrieb Pablo Neira Ayuso : >Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy >and >stats to different workqueues") splits the workqueue per event type. >Add >a mutex to serialize updates. > >Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add f

Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-19 Thread Jakub Kicinski
On Mon, 19 Apr 2021 23:54:32 +0200 Pablo Neira Ayuso wrote: > On Mon, Apr 19, 2021 at 02:43:41PM -0700, Jakub Kicinski wrote: > > On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote: > > > No rtnl lock is held from the netfilter side, see: > > > > > > 42f1c2712090 ("netfilter: nftables: c

Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-19 Thread Pablo Neira Ayuso
On Mon, Apr 19, 2021 at 02:43:41PM -0700, Jakub Kicinski wrote: > On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote: > > On Mon, Apr 19, 2021 at 02:16:01PM -0700, Jakub Kicinski wrote: > > > On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote: > > > > Patch 2ed37183abb7 ("netfilte

Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-19 Thread Jakub Kicinski
On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote: > On Mon, Apr 19, 2021 at 02:16:01PM -0700, Jakub Kicinski wrote: > > On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote: > > > Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and > > > stats to different wor

Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-19 Thread Pablo Neira Ayuso
On Mon, Apr 19, 2021 at 02:16:01PM -0700, Jakub Kicinski wrote: > On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote: > > Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and > > stats to different workqueues") splits the workqueue per event type. Add > > a mutex to seri

Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-19 Thread Jakub Kicinski
On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote: > Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and > stats to different workqueues") splits the workqueue per event type. Add > a mutex to serialize updates. > > Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: ad

[PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

2021-04-18 Thread Pablo Neira Ayuso
Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and stats to different workqueues") splits the workqueue per event type. Add a mutex to serialize updates. Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support") Reported-by: Frank Wunderlich Signed-off-