Re: [PATCH net-next 2/2] pfifo_fast: drop unneeded additional lock on dequeue

2018-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2018 at 09:56:16AM +0200, Paolo Abeni wrote: > On Tue, 2018-05-15 at 23:17 +0300, Michael S. Tsirkin wrote: > > On Tue, May 15, 2018 at 04:24:37PM +0200, Paolo Abeni wrote: > > > After the previous patch, for NOLOCK qdiscs, q->seqlock is > > > always held when the dequeue() is invok

Re: [PATCH net-next 2/2] pfifo_fast: drop unneeded additional lock on dequeue

2018-05-16 Thread Paolo Abeni
On Wed, 2018-05-16 at 09:56 +0200, Paolo Abeni wrote: > On Tue, 2018-05-15 at 23:17 +0300, Michael S. Tsirkin wrote: > > On Tue, May 15, 2018 at 04:24:37PM +0200, Paolo Abeni wrote: > > > After the previous patch, for NOLOCK qdiscs, q->seqlock is > > > always held when the dequeue() is invoked, we

Re: [PATCH net-next 2/2] pfifo_fast: drop unneeded additional lock on dequeue

2018-05-16 Thread Paolo Abeni
On Tue, 2018-05-15 at 23:17 +0300, Michael S. Tsirkin wrote: > On Tue, May 15, 2018 at 04:24:37PM +0200, Paolo Abeni wrote: > > After the previous patch, for NOLOCK qdiscs, q->seqlock is > > always held when the dequeue() is invoked, we can drop > > any additional locking to protect such operation.

Re: [PATCH net-next 2/2] pfifo_fast: drop unneeded additional lock on dequeue

2018-05-15 Thread Michael S. Tsirkin
On Tue, May 15, 2018 at 04:24:37PM +0200, Paolo Abeni wrote: > After the previous patch, for NOLOCK qdiscs, q->seqlock is > always held when the dequeue() is invoked, we can drop > any additional locking to protect such operation. > > Signed-off-by: Paolo Abeni > --- > include/linux/skb_array.h

[PATCH net-next 2/2] pfifo_fast: drop unneeded additional lock on dequeue

2018-05-15 Thread Paolo Abeni
After the previous patch, for NOLOCK qdiscs, q->seqlock is always held when the dequeue() is invoked, we can drop any additional locking to protect such operation. Signed-off-by: Paolo Abeni --- include/linux/skb_array.h | 5 + net/sched/sch_generic.c | 4 ++-- 2 files changed, 7 insertion