Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

2020-07-23 Thread Florian Westphal
Eelco Chaudron wrote: > On 22 Jul 2020, at 21:22, Florian Westphal wrote: > > I see a 0 cache size is legal (turns it off) and that the allocation > > path has a few sanity checks as well. > > > > Would it make sense to add min/max policy to datapath_policy[] for this > > as well? > > Yes I coul

Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

2020-07-23 Thread Eelco Chaudron
On 22 Jul 2020, at 21:22, Florian Westphal wrote: Eelco Chaudron wrote: This patch makes the masks cache size configurable, or with a size of 0, disable it. Reviewed-by: Paolo Abeni Signed-off-by: Eelco Chaudron --- include/uapi/linux/openvswitch.h |1 net/openvswitch/datapath.c

Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

2020-07-22 Thread Florian Westphal
Eelco Chaudron wrote: > This patch makes the masks cache size configurable, or with > a size of 0, disable it. > > Reviewed-by: Paolo Abeni > Signed-off-by: Eelco Chaudron > --- > include/uapi/linux/openvswitch.h |1 > net/openvswitch/datapath.c | 11 + > net/openvswitch/flow_

Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

2020-07-22 Thread kernel test robot
Hi Eelco, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Eelco-Chaudron/net-openvswitch-masks-cache-enhancements/20200722-163017 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

2020-07-22 Thread Eelco Chaudron
On 22 Jul 2020, at 17:21, Jakub Kicinski wrote: On Wed, 22 Jul 2020 10:27:52 +0200 Eelco Chaudron wrote: This patch makes the masks cache size configurable, or with a size of 0, disable it. Reviewed-by: Paolo Abeni Signed-off-by: Eelco Chaudron Hi Elco! This patch adds a bunch of new s

Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

2020-07-22 Thread Jakub Kicinski
On Wed, 22 Jul 2020 10:27:52 +0200 Eelco Chaudron wrote: > This patch makes the masks cache size configurable, or with > a size of 0, disable it. > > Reviewed-by: Paolo Abeni > Signed-off-by: Eelco Chaudron Hi Elco! This patch adds a bunch of new sparse warnings: net/openvswitch/flow_table.c:

[PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

2020-07-22 Thread Eelco Chaudron
This patch makes the masks cache size configurable, or with a size of 0, disable it. Reviewed-by: Paolo Abeni Signed-off-by: Eelco Chaudron --- include/uapi/linux/openvswitch.h |1 net/openvswitch/datapath.c | 11 + net/openvswitch/flow_table.c | 86 ++