Re: [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink

2017-03-29 Thread Jiri Pirko
Wed, Mar 29, 2017 at 07:36:24PM CEST, and...@lunn.ch wrote: >> Tangential question: we do not currently report to user space what kind >> of switch tagging protocol is used (DSA, eDSA etc.) I was going to add a >> sysfs attribute for that under the switch device's directory, but maybe >> devlink wo

Re: [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink

2017-03-29 Thread Andrew Lunn
> Tangential question: we do not currently report to user space what kind > of switch tagging protocol is used (DSA, eDSA etc.) I was going to add a > sysfs attribute for that under the switch device's directory, but maybe > devlink would be more appropriate for that? We don't report it. What are

Re: [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink

2017-03-29 Thread Florian Fainelli
On 03/28/2017 06:31 PM, Andrew Lunn wrote: > On Tue, Mar 28, 2017 at 05:33:18PM -0700, Florian Fainelli wrote: >> On 03/28/2017 02:45 PM, Andrew Lunn wrote: >>> Register the switch and its ports with devlink. >>> >>> Signed-off-by: Andrew Lunn >> >> Reviewed-by: Florian Fainelli >> Tested-by: Flo

Re: [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink

2017-03-28 Thread Andrew Lunn
On Tue, Mar 28, 2017 at 05:33:18PM -0700, Florian Fainelli wrote: > On 03/28/2017 02:45 PM, Andrew Lunn wrote: > > Register the switch and its ports with devlink. > > > > Signed-off-by: Andrew Lunn > > Reviewed-by: Florian Fainelli > Tested-by: Florian Fainelli > > root@net-vm:~# devlink -p p

Re: [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink

2017-03-28 Thread Florian Fainelli
On 03/28/2017 02:45 PM, Andrew Lunn wrote: > Register the switch and its ports with devlink. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli Tested-by: Florian Fainelli root@net-vm:~# devlink -p port mdio_bus/fixed-0:1f/0: type eth netdev lan1 mdio_bus/fixed-0:1f/1: type eth netd

[PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink

2017-03-28 Thread Andrew Lunn
Register the switch and its ports with devlink. Signed-off-by: Andrew Lunn --- include/net/dsa.h | 5 + net/dsa/dsa2.c| 47 +-- 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/include/net/dsa.h b/include/net/dsa.h index f80e819