Re: [PATCH net-next 12/18] ionic: Add async link status check and basic stats

2019-06-26 Thread Shannon Nelson
On 6/25/19 4:47 PM, Jakub Kicinski wrote: On Thu, 20 Jun 2019 13:24:18 -0700, Shannon Nelson wrote: + /* filter out the no-change cases */ + if ((link_up && netif_carrier_ok(netdev)) || + (!link_up && !netif_carrier_ok(netdev))) nit: these are both bools, you can compare t

Re: [PATCH net-next 12/18] ionic: Add async link status check and basic stats

2019-06-25 Thread Jakub Kicinski
On Thu, 20 Jun 2019 13:24:18 -0700, Shannon Nelson wrote: > + /* filter out the no-change cases */ > + if ((link_up && netif_carrier_ok(netdev)) || > + (!link_up && !netif_carrier_ok(netdev))) nit: these are both bools, you can compare them: if (link_up == netif_carrier_ok

[PATCH net-next 12/18] ionic: Add async link status check and basic stats

2019-06-20 Thread Shannon Nelson
Add code to handle the link status event, and wire up the basic netdev hardware stats. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_lif.c | 117 ++ .../net/ethernet/pensando/ionic/ionic_lif.h | 1 + 2 files changed, 118 insertions(+) diff --git a