Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-07 Thread Christian Brauner
On Fri, Oct 05, 2018 at 01:25:22PM -0600, David Ahern wrote: > On 10/5/18 11:48 AM, Christian Brauner wrote: > > On Thu, Oct 04, 2018 at 02:33:46PM -0700, David Ahern wrote: > >> From: David Ahern > >> > >> Update inet6_dump_ifinfo for strict data checking. If the flag is > >> set, the dump reques

Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-07 Thread Christian Brauner
On Fri, Oct 05, 2018 at 01:26:31PM -0600, David Ahern wrote: > On 10/5/18 11:54 AM, Christian Brauner wrote: > >> +static int inet6_valid_dump_ifinfo(const struct nlmsghdr *nlh, > >> + struct netlink_ext_ack *extack) > >> +{ > >> + struct ifinfomsg *ifm; > >> + > >> +

Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-05 Thread David Ahern
On 10/5/18 11:54 AM, Christian Brauner wrote: >> +static int inet6_valid_dump_ifinfo(const struct nlmsghdr *nlh, >> + struct netlink_ext_ack *extack) >> +{ >> +struct ifinfomsg *ifm; >> + >> +if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*ifm))) { >> +

Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-05 Thread David Ahern
On 10/5/18 11:48 AM, Christian Brauner wrote: > On Thu, Oct 04, 2018 at 02:33:46PM -0700, David Ahern wrote: >> From: David Ahern >> >> Update inet6_dump_ifinfo for strict data checking. If the flag is >> set, the dump request is expected to have an ifinfomsg struct as >> the header. All elements

Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-05 Thread Christian Brauner
On Thu, Oct 04, 2018 at 02:33:46PM -0700, David Ahern wrote: > From: David Ahern > > Update inet6_dump_ifinfo for strict data checking. If the flag is > set, the dump request is expected to have an ifinfomsg struct as > the header. All elements of the struct are expected to be 0 and no > attribut

Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-05 Thread Christian Brauner
On Fri, Oct 05, 2018 at 07:48:27PM +0200, Christian Brauner wrote: > On Thu, Oct 04, 2018 at 02:33:46PM -0700, David Ahern wrote: > > From: David Ahern > > > > Update inet6_dump_ifinfo for strict data checking. If the flag is > > set, the dump request is expected to have an ifinfomsg struct as >

Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-05 Thread Christian Brauner
On Thu, Oct 04, 2018 at 02:33:46PM -0700, David Ahern wrote: > From: David Ahern > > Update inet6_dump_ifinfo for strict data checking. If the flag is > set, the dump request is expected to have an ifinfomsg struct as > the header. All elements of the struct are expected to be 0 and no > attribut

[PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking

2018-10-04 Thread David Ahern
From: David Ahern Update inet6_dump_ifinfo for strict data checking. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by: David Ahern --- net/ipv6/addrconf.c