Re: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev

2019-01-22 Thread Ivan Khoronzhuk
On Thu, Jan 17, 2019 at 11:12:24AM -0800, Florian Fainelli wrote: On 1/17/19 6:49 AM, Ido Schimmel wrote: On Wed, Jan 16, 2019 at 12:00:58PM -0800, Florian Fainelli wrote: The VLAN real device could be an Ethernet switch port and that switch might have VLAN filtering globally enabled (because o

Re: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev

2019-01-22 Thread Ivan Khoronzhuk
On Mon, Jan 21, 2019 at 09:13:01AM +, Ido Schimmel wrote: On Thu, Jan 17, 2019 at 11:12:24AM -0800, Florian Fainelli wrote: On 1/17/19 6:49 AM, Ido Schimmel wrote: > On Wed, Jan 16, 2019 at 12:00:58PM -0800, Florian Fainelli wrote: >> The VLAN real device could be an Ethernet switch port and

Re: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev

2019-01-21 Thread Ilias Apalodimas
Hi Ido, > > > > The reason why I chose switchdev here is because: > > > > - this is mostly relevant for switch devices, not so much for NICs (it > > seems), if it was, they would have solved the problem by now > > I don't see any use of switchdev APIs in the driver Ivan is patching. > The cover

Re: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev

2019-01-21 Thread Ido Schimmel
On Thu, Jan 17, 2019 at 11:12:24AM -0800, Florian Fainelli wrote: > On 1/17/19 6:49 AM, Ido Schimmel wrote: > > On Wed, Jan 16, 2019 at 12:00:58PM -0800, Florian Fainelli wrote: > >> The VLAN real device could be an Ethernet switch port and that switch > >> might have VLAN filtering globally enable

Re: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev

2019-01-17 Thread Florian Fainelli
On 1/17/19 6:49 AM, Ido Schimmel wrote: > On Wed, Jan 16, 2019 at 12:00:58PM -0800, Florian Fainelli wrote: >> The VLAN real device could be an Ethernet switch port and that switch >> might have VLAN filtering globally enabled (because of a bridge >> requesting VLAN filtering on the switch on anoth

Re: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev

2019-01-17 Thread Ido Schimmel
On Wed, Jan 16, 2019 at 12:00:58PM -0800, Florian Fainelli wrote: > The VLAN real device could be an Ethernet switch port and that switch > might have VLAN filtering globally enabled (because of a bridge > requesting VLAN filtering on the switch on another port) and so when > programming multicast

[PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev

2019-01-16 Thread Florian Fainelli
The VLAN real device could be an Ethernet switch port and that switch might have VLAN filtering globally enabled (because of a bridge requesting VLAN filtering on the switch on another port) and so when programming multicast addresses, we need the multicast filter programming to be aware of the cor