Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-08-07 Thread Jesse Gross
On Tue, Aug 4, 2015 at 9:40 PM, Joe Stringer wrote: > On 1 August 2015 at 12:17, Thomas Graf wrote: >> On 07/31/15 at 10:51am, Joe Stringer wrote: >>> On 31 July 2015 at 07:34, Hannes Frederic Sowa wrote: >>> > In general, this shouldn't be necessary as the packet should already be >>> > scrubbe

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-08-04 Thread Joe Stringer
On 1 August 2015 at 12:17, Thomas Graf wrote: > On 07/31/15 at 10:51am, Joe Stringer wrote: >> On 31 July 2015 at 07:34, Hannes Frederic Sowa wrote: >> > In general, this shouldn't be necessary as the packet should already be >> > scrubbed before they arrive here. >> > >> > Could you maybe add a

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-08-01 Thread Thomas Graf
On 07/31/15 at 10:51am, Joe Stringer wrote: > On 31 July 2015 at 07:34, Hannes Frederic Sowa wrote: > > In general, this shouldn't be necessary as the packet should already be > > scrubbed before they arrive here. > > > > Could you maybe add a WARN_ON and check how those skbs with conntrack > > da

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-31 Thread Joe Stringer
On 31 July 2015 at 07:34, Hannes Frederic Sowa wrote: > On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: >> Signed-off-by: Joe Stringer >> --- >> net/openvswitch/vport.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c >> inde

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-31 Thread Hannes Frederic Sowa
On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > net/openvswitch/vport.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c > index d14f594..baa018f 100644 > --- a/net/openvswitch/vport.c > +++

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-31 Thread Thomas Graf
On 07/30/15 at 04:16pm, Joe Stringer wrote: > On 30 July 2015 at 11:40, Thomas Graf wrote: > > On 07/30/15 at 11:12am, Joe Stringer wrote: > >> Signed-off-by: Joe Stringer > > > > Can you write a few lines on why this is needed? I have flows which > > use the mark to communicate with netfilter th

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-30 Thread Pravin Shelar
On Thu, Jul 30, 2015 at 11:12 AM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > net/openvswitch/vport.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c > index d14f594..baa018f 100644 > --- a/net/openvswitch/vport.c > +++

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-30 Thread Joe Stringer
On 30 July 2015 at 11:40, Thomas Graf wrote: > On 07/30/15 at 11:12am, Joe Stringer wrote: >> Signed-off-by: Joe Stringer > > Can you write a few lines on why this is needed? I have flows which > use the mark to communicate with netfilter through internal ports. The problem I was seeing is when

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-30 Thread Thomas Graf
On 07/30/15 at 11:12am, Joe Stringer wrote: > Signed-off-by: Joe Stringer Can you write a few lines on why this is needed? I have flows which use the mark to communicate with netfilter through internal ports. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

[PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-30 Thread Joe Stringer
Signed-off-by: Joe Stringer --- net/openvswitch/vport.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index d14f594..baa018f 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -475,6 +475,9 @@ void ovs_vport_receive(str