Re: [PATCH net-next 1/7] sfc: decouple TXQ type from label

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 18:36:04 +0100 Edward Cree wrote: > >> + /* We don't have a TXQ of the right type. > >> + * This should never happen, as we don't advertise offload > >> + * features unless we can support them. > >> + */ > >> + return NETDEV_TX_BUS

Re: [PATCH net-next 1/7] sfc: decouple TXQ type from label

2020-09-11 Thread Edward Cree
On 11/09/2020 16:53, Jakub Kicinski wrote: > On Thu, 10 Sep 2020 21:31:29 +0100 Edward Cree wrote: >> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c >> index 48d91b26f1a2..b0a08d9f4773 100644 >> --- a/drivers/net/ethernet/sfc/tx.c >> +++ b/drivers/net/ethernet/sfc/tx.c >

Re: [PATCH net-next 1/7] sfc: decouple TXQ type from label

2020-09-11 Thread Jakub Kicinski
On Thu, 10 Sep 2020 21:31:29 +0100 Edward Cree wrote: > diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c > index 48d91b26f1a2..b0a08d9f4773 100644 > --- a/drivers/net/ethernet/sfc/tx.c > +++ b/drivers/net/ethernet/sfc/tx.c > @@ -527,6 +527,12 @@ netdev_tx_t efx_hard_start_

[PATCH net-next 1/7] sfc: decouple TXQ type from label

2020-09-10 Thread Edward Cree
Make it possible to have an arbitrary mapping from types to labels, because when we add inner-csum-offload TXQs there will no longer be a convenient nesting hierarchy of NIC types (EF10 will have inner-csum TXQs, while Siena will have HIGHPRI). Signed-off-by: Edward Cree --- drivers/net/ether