Re: [PATCH net-next 1/6] r8169: change driver data type

2020-05-31 Thread Heiner Kallweit
On 31.05.2020 07:17, Stephen Hemminger wrote: > On Sat, 30 May 2020 23:54:36 +0200 > Heiner Kallweit wrote: > >> Change driver private data type to struct rtl8169_private * to avoid >> some overhead. >> >> Signed-off-by: Heiner Kallweit >> --- > > Are you sure about this. Using netdev_priv() is

Re: [PATCH net-next 1/6] r8169: change driver data type

2020-05-30 Thread Stephen Hemminger
On Sat, 30 May 2020 23:54:36 +0200 Heiner Kallweit wrote: > Change driver private data type to struct rtl8169_private * to avoid > some overhead. > > Signed-off-by: Heiner Kallweit > --- Are you sure about this. Using netdev_priv() is actually at a fixed offset from netdev, and almost always t

[PATCH net-next 1/6] r8169: change driver data type

2020-05-30 Thread Heiner Kallweit
Change driver private data type to struct rtl8169_private * to avoid some overhead. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 60 ++- 1 file changed, 25 insertions(+), 35 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c