Re: [PATCH net-next 1/5] sfc: add and use efx_tx_send_pending in tx.c

2020-09-03 Thread Edward Cree
On 02/09/2020 23:55, David Miller wrote: > From: Edward Cree > Date: Wed, 2 Sep 2020 15:35:53 +0100 > >> +tx_queue->xmit_more_available = true; > > I don't understand why you're setting xmit_more_available > unconditionally to true now instead of setting it to 'xmit_more' as > seen by this t

Re: [PATCH net-next 1/5] sfc: add and use efx_tx_send_pending in tx.c

2020-09-02 Thread David Miller
From: Edward Cree Date: Wed, 2 Sep 2020 15:35:53 +0100 > + tx_queue->xmit_more_available = true; I don't understand why you're setting xmit_more_available unconditionally to true now instead of setting it to 'xmit_more' as seen by this transmit attempt. Why would you want to signal that xmi

[PATCH net-next 1/5] sfc: add and use efx_tx_send_pending in tx.c

2020-09-02 Thread Edward Cree
Instead of using efx_tx_queue_partner(), which relies on the assumption that tx_queues_per_channel is 2, efx_tx_send_pending() iterates over txqs with efx_for_each_channel_tx_queue(). Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/tx.c | 59 ++- 1 file