Re: [PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero

2019-02-21 Thread Tonghao Zhang
On Fri, Feb 22, 2019 at 12:27 AM Or Gerlitz wrote: > > On Thu, Feb 21, 2019 at 3:42 PM wrote: > > else /* namespace is MLX5_FLOW_NAMESPACE_KERNEL - NIC offloading */ > > max_actions = MLX5_CAP_FLOWTABLE_NIC_RX(priv->mdev, > > max_modify_header_actions); > > > > + if

Re: [PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero

2019-02-21 Thread Or Gerlitz
On Thu, Feb 21, 2019 at 3:42 PM wrote: > else /* namespace is MLX5_FLOW_NAMESPACE_KERNEL - NIC offloading */ > max_actions = MLX5_CAP_FLOWTABLE_NIC_RX(priv->mdev, > max_modify_header_actions); > > + if (!max_actions) { > + NL_SET_ERR_MSG_MOD(extack, > +

[PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero

2019-02-21 Thread xiangxia . m . yue
From: Tonghao Zhang When max modify header action is zero, we return -EOPNOTSUPP directly. In this way, we can ignore wrong message info (e.g. "mlx5: parsed 0 pedit actions, can't do more"). This happens when offloading pedit actions on mlx VFs. For example: $ tc filter add dev mlx_vfs parent f