Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Herbert Xu
On Tue, Jul 14, 2015 at 05:59:53PM -0700, Tom Herbert wrote: > > Conceptually, I agree with you, but I would point out that we've had > this model of intentional collisions for a while in socket lookup. I > would assume that it's a goal to use rhashtable for socket tables, so > we'll need some solu

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 4:58 PM, Herbert Xu wrote: > On Tue, Jul 14, 2015 at 09:42:49AM -0700, Tom Herbert wrote: >> >> Scored lookups can provides the same functionality, but requires that >> we scan all the elements so I see some overhead compared to doing >> ordered insertion. One way to resolv

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Herbert Xu
On Tue, Jul 14, 2015 at 09:42:49AM -0700, Tom Herbert wrote: > > Scored lookups can provides the same functionality, but requires that > we scan all the elements so I see some overhead compared to doing > ordered insertion. One way to resolve the rehash problem is search any > future table after we

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 2:57 AM, Herbert Xu wrote: > Tom Herbert wrote: >> The obj_orderfn function may be specified in the parameters for a >> rhashtable. When inserting an element this function is used to order >> objects in a bucket list (greatest to least ordering value).This >> allows entrie

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Herbert Xu
Tom Herbert wrote: > The obj_orderfn function may be specified in the parameters for a > rhashtable. When inserting an element this function is used to order > objects in a bucket list (greatest to least ordering value).This > allows entries to have wild card fields, where entries with > more spec

[PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-13 Thread Tom Herbert
The obj_orderfn function may be specified in the parameters for a rhashtable. When inserting an element this function is used to order objects in a bucket list (greatest to least ordering value).This allows entries to have wild card fields, where entries with more specific information match are pla