Re: [PATCH net-next 1/3] net: dsa: make the STP state function return void

2016-04-05 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> -- port_stp_update: bridge layer function invoked when a given switch port >> STP >> +- port_stp_state: bridge layer function invoked when a given switch port STP > > port_stp_state_set might be a better name, to make it clear it is > setting the state, not get

Re: [PATCH net-next 1/3] net: dsa: make the STP state function return void

2016-04-05 Thread Andrew Lunn
> -- port_stp_update: bridge layer function invoked when a given switch port STP > +- port_stp_state: bridge layer function invoked when a given switch port STP Hi Vivien port_stp_state_set might be a better name, to make it clear it is setting the state, not getting the current state, etc. Most

[PATCH net-next 1/3] net: dsa: make the STP state function return void

2016-04-05 Thread Vivien Didelot
The DSA layer doesn't care about the return code of the port_stp_update routine, so make it void in the layer and the DSA drivers. Replace the useless dsa_slave_stp_update function with a dsa_slave_stp_state function used to reply to the switchdev SWITCHDEV_ATTR_ID_PORT_STP_STATE attribute. In th