Re: [PATCH net-next 1/3] macsec: remove superfluous function calls

2019-07-02 Thread Willem de Bruijn
On Sun, Jun 30, 2019 at 9:57 PM Willem de Bruijn wrote: > > On Sun, Jun 30, 2019 at 4:48 PM Andreas Steinmetz wrote: > > > > Remove superfluous skb_share_check() and skb_unshare(). > > macsec_decrypt is only called by macsec_handle_frame which > > already does a skb_unshare(). > > There is a subt

Re: [PATCH net-next 1/3] macsec: remove superfluous function calls

2019-06-30 Thread Willem de Bruijn
On Sun, Jun 30, 2019 at 4:48 PM Andreas Steinmetz wrote: > > Remove superfluous skb_share_check() and skb_unshare(). > macsec_decrypt is only called by macsec_handle_frame which > already does a skb_unshare(). There is a subtle difference. skb_unshare() acts on cloned skbs, not shared skbs. It c

[PATCH net-next 1/3] macsec: remove superfluous function calls

2019-06-30 Thread Andreas Steinmetz
Remove superfluous skb_share_check() and skb_unshare(). macsec_decrypt is only called by macsec_handle_frame which already does a skb_unshare(). Signed-off-by: Andreas Steinmetz --- a/drivers/net/macsec.c 2019-06-30 22:02:54.906908179 +0200 +++ b/drivers/net/macsec.c 2019-06-30 22:03:0