Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-26 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Sat, 23 Feb 2019 13:11:02 +0100, Toke Høiland-Jørgensen wrote: >> Jesper Dangaard Brouer writes: >> > On Fri, 22 Feb 2019 13:37:34 -0800 Jakub Kicinski wrote: >> >> On Fri, 22 Feb 2019 11:13:50 +0100, Toke Høiland-Jørgensen wrote: >> >> > Jakub Kicinski writes:

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-25 Thread Jakub Kicinski
On Sat, 23 Feb 2019 13:11:02 +0100, Toke Høiland-Jørgensen wrote: > Jesper Dangaard Brouer writes: > > On Fri, 22 Feb 2019 13:37:34 -0800 Jakub Kicinski wrote: > >> On Fri, 22 Feb 2019 11:13:50 +0100, Toke Høiland-Jørgensen wrote: > >> > Jakub Kicinski writes: > >> > > On Thu, 21 Feb 2019 1

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-23 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Fri, 22 Feb 2019 13:37:34 -0800 Jakub Kicinski > wrote: > >> On Fri, 22 Feb 2019 11:13:50 +0100, Toke Høiland-Jørgensen wrote: >> > Jakub Kicinski writes: >> > > On Thu, 21 Feb 2019 12:56:54 +0100, Toke Høiland-Jørgensen wrote: > [...] >> > > >> > > BP

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-23 Thread Jesper Dangaard Brouer
On Fri, 22 Feb 2019 13:37:34 -0800 Jakub Kicinski wrote: > On Fri, 22 Feb 2019 11:13:50 +0100, Toke Høiland-Jørgensen wrote: > > Jakub Kicinski writes: > > > On Thu, 21 Feb 2019 12:56:54 +0100, Toke Høiland-Jørgensen wrote: [...] > > > > > > BPF programs don't obey by netns boundaries.

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-22 Thread Jakub Kicinski
On Fri, 22 Feb 2019 11:13:50 +0100, Toke Høiland-Jørgensen wrote: > Jakub Kicinski writes: > > On Thu, 21 Feb 2019 12:56:54 +0100, Toke Høiland-Jørgensen wrote: > >> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > >> index b63bc77af2d1..629661db36ee 100644 > >> --- a/kernel/bpf/veri

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-22 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Thu, 21 Feb 2019 12:56:54 +0100, Toke Høiland-Jørgensen wrote: >> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c >> index b63bc77af2d1..629661db36ee 100644 >> --- a/kernel/bpf/verifier.c >> +++ b/kernel/bpf/verifier.c >> @@ -7527,6 +7527,12 @@ static int fi

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-21 Thread Jakub Kicinski
On Thu, 21 Feb 2019 12:56:54 +0100, Toke Høiland-Jørgensen wrote: > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > index b63bc77af2d1..629661db36ee 100644 > --- a/kernel/bpf/verifier.c > +++ b/kernel/bpf/verifier.c > @@ -7527,6 +7527,12 @@ static int fixup_bpf_calls(struct bpf_verifie

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-21 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > You forgot at cover letter describing why we are doing this... > even-though is should be obvious from the performance results ;-) Well, I tried to put the motivation into the first paragraph of each patch description instead of as a separate cover letter. I gues

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-21 Thread Jesper Dangaard Brouer
You forgot at cover letter describing why we are doing this... even-though is should be obvious from the performance results ;-) On Thu, 21 Feb 2019 12:56:54 +0100 Toke Høiland-Jørgensen wrote: > Before patch: > xdp_redirect: 5426035 pkt/s > xdp_redirect_map: 8412754 pkt/s > > After pat

[PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-21 Thread Toke Høiland-Jørgensen
An XDP program can redirect packets between interfaces using either the xdp_redirect() helper or the xdp_redirect_map() helper. Apart from the flexibility of updating maps from userspace, the redirect_map() helper also uses the map structure to batch packets, which results in a significant (around