Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jose Abreu
Hi Jerome, On 04-09-2018 13:27, Jerome Brunet wrote: > On Tue, 2018-09-04 at 10:57 +0100, Jose Abreu wrote: >> Hi Jerome, >> >> On 03-09-2018 17:22, Jerome Brunet wrote: >>> Situation is even worse with this. >>> I'm using an NFS root filesystem. With your fixup, I'm not reaching the >>> prompt >

Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jerome Brunet
On Tue, 2018-09-04 at 10:57 +0100, Jose Abreu wrote: > Hi Jerome, > > On 03-09-2018 17:22, Jerome Brunet wrote: > > > > Situation is even worse with this. > > I'm using an NFS root filesystem. With your fixup, I'm not reaching the > > prompt > > anymore. Looks like a the same kind of network bre

Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jose Abreu
Hi Jerome, On 03-09-2018 17:22, Jerome Brunet wrote: > > Situation is even worse with this. > I'm using an NFS root filesystem. With your fixup, I'm not reaching the prompt > anymore. Looks like a the same kind of network breakdown we had previously > I was able to reproduce your problem and the

Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jerome Brunet
On Mon, 2018-09-03 at 16:19 +0100, Jose Abreu wrote: > On 03-09-2018 15:07, Jerome Brunet wrote: > > > > You had it on what you sent in the RFT, but this different. > > Yeah, I had to fix the logic where tx queues != rx queues... > > > > > Like with the RFT, the network breakdown we had is no l

Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jose Abreu
On 03-09-2018 15:07, Jerome Brunet wrote: > > You had it on what you sent in the RFT, but this different. Yeah, I had to fix the logic where tx queues != rx queues... > > Like with the RFT, the network breakdown we had is no longer reproduced. > However this patch wreck the Rx throughput (680MBps

Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jerome Brunet
On Mon, 2018-09-03 at 14:35 +0100, Jose Abreu wrote: > This follows David Miller advice and tries to fix coalesce timer in > multi-queue scenarios. > > We are now using per-queue coalesce values and per-queue TX timer. > > Coalesce timer default values was changed to 1ms and the coalesce frames >

[PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jose Abreu
This follows David Miller advice and tries to fix coalesce timer in multi-queue scenarios. We are now using per-queue coalesce values and per-queue TX timer. Coalesce timer default values was changed to 1ms and the coalesce frames to 25. Tested in B2B setup between XGMAC2 and GMAC5. Signed-off-