Re: [PATCH net-next 1/2] bpf: don't enable preemption twice in smap_do_verdict

2017-08-17 Thread Alexei Starovoitov
On 8/17/17 9:03 AM, John Fastabend wrote: On 08/17/2017 08:22 AM, Daniel Borkmann wrote: In smap_do_verdict(), the fall-through branch leads to call preempt_enable() twice for the SK_REDIRECT, which creates an imbalance. Only enable it for all remaining cases again. Fixes: 174a79ff9515 ("bpf: s

Re: [PATCH net-next 1/2] bpf: don't enable preemption twice in smap_do_verdict

2017-08-17 Thread John Fastabend
On 08/17/2017 08:22 AM, Daniel Borkmann wrote: > In smap_do_verdict(), the fall-through branch leads to call > preempt_enable() twice for the SK_REDIRECT, which creates an > imbalance. Only enable it for all remaining cases again. > > Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") >

[PATCH net-next 1/2] bpf: don't enable preemption twice in smap_do_verdict

2017-08-17 Thread Daniel Borkmann
In smap_do_verdict(), the fall-through branch leads to call preempt_enable() twice for the SK_REDIRECT, which creates an imbalance. Only enable it for all remaining cases again. Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") Reported-by: Alexei Starovoitov Signed-off-by: Daniel Bor