Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread David Miller
From: f...@ikuai8.com Date: Fri, 17 Feb 2017 14:34:19 +0800 > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already makes sure only o

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread Eric Dumazet
On Fri, 2017-02-17 at 10:02 -0800, Cong Wang wrote: > On Thu, Feb 16, 2017 at 10:34 PM, wrote: > > From: Gao Feng > > > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > > These two functions are invoked in qdisc_create, qdisc_change, and > > qdisc_destroy which run fully und

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread Eric Dumazet
On Fri, 2017-02-17 at 14:34 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already makes sure only one

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread Cong Wang
On Thu, Feb 16, 2017 at 10:34 PM, wrote: > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already makes sure only one could access the

[PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-16 Thread fgao
From: Gao Feng The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. These two functions are invoked in qdisc_create, qdisc_change, and qdisc_destroy which run fully under RTNL. So it already makes sure only one could access the qdisc_stab_list at the same time. Then it is unnecessar