Re: [PATCH net-next 1/1] ice: Improve MSI-X vector enablement fallback logic

2021-01-21 Thread Venkataramanan, Anirudh
On Tue, 2021-01-19 at 18:29 -0800, Jakub Kicinski wrote: > On Wed, 20 Jan 2021 02:13:36 + Venkataramanan, Anirudh wrote: > > > > As per the current logic, if the driver does not get the number > > > > of > > > > MSI- > > > > X vectors it needs, it will immediately drop to "Do I have at > > > >

Re: [PATCH net-next 1/1] ice: Improve MSI-X vector enablement fallback logic

2021-01-19 Thread Jakub Kicinski
On Wed, 20 Jan 2021 02:13:36 + Venkataramanan, Anirudh wrote: > > > As per the current logic, if the driver does not get the number of > > > MSI- > > > X vectors it needs, it will immediately drop to "Do I have at least > > > two > > > (ICE_MIN_LAN_VECS) MSI-X vectors?". If yes, the driver will

Re: [PATCH net-next 1/1] ice: Improve MSI-X vector enablement fallback logic

2021-01-19 Thread Venkataramanan, Anirudh
On Tue, 2021-01-19 at 16:41 -0800, Jakub Kicinski wrote: > On Wed, 20 Jan 2021 00:12:26 + Venkataramanan, Anirudh wrote: > > > > Attempt [0]: Enable the best-case scenario MSI-X vectors. > > > > > > > > Attempt [1]: Enable MSI-X vectors with the number of pf- > > > > > num_lan_msix > > > >

Re: [PATCH net-next 1/1] ice: Improve MSI-X vector enablement fallback logic

2021-01-19 Thread Jakub Kicinski
On Wed, 20 Jan 2021 00:12:26 + Venkataramanan, Anirudh wrote: > > > Attempt [0]: Enable the best-case scenario MSI-X vectors. > > > > > > Attempt [1]: Enable MSI-X vectors with the number of pf- > > > >num_lan_msix > > > reduced by a factor of 2 from the previous attempt (i.e. > > > num_on

Re: [PATCH net-next 1/1] ice: Improve MSI-X vector enablement fallback logic

2021-01-19 Thread Venkataramanan, Anirudh
On Thu, 2021-01-14 at 16:42 -0800, Jakub Kicinski wrote: > On Wed, 13 Jan 2021 15:42:26 -0800 Tony Nguyen wrote: > > From: Brett Creeley > > > > The current MSI-X enablement logic either tries to enable best-case > > MSI-X vectors and if that fails we only support a bare-minimum set. > > This is

Re: [PATCH net-next 1/1] ice: Improve MSI-X vector enablement fallback logic

2021-01-14 Thread Jakub Kicinski
On Wed, 13 Jan 2021 15:42:26 -0800 Tony Nguyen wrote: > From: Brett Creeley > > The current MSI-X enablement logic either tries to enable best-case > MSI-X vectors and if that fails we only support a bare-minimum set. > This is not very flexible and the current logic is broken when actually > all

[PATCH net-next 1/1] ice: Improve MSI-X vector enablement fallback logic

2021-01-13 Thread Tony Nguyen
From: Brett Creeley The current MSI-X enablement logic either tries to enable best-case MSI-X vectors and if that fails we only support a bare-minimum set. This is not very flexible and the current logic is broken when actually allocating and reserving MSI-X in the driver. Fix this by improving t