Re: [PATCH net-next 1/1] e1000: remove dead e1000_init_eeprom_params calls.

2015-08-03 Thread Jeff Kirsher
On Fri, Jul 24, 2015 at 2:40 PM, Francois Romieu wrote: > The device probe method e1000_probe calls e1000_init_eeprom_params > itself so there's no reason to call it again from e1000_do_write_eeprom > or e1000_do_read_eeprom. > > The sentence above assumes that e1000_init_eeprom_params is effectiv

[PATCH net-next 1/1] e1000: remove dead e1000_init_eeprom_params calls.

2015-07-24 Thread Francois Romieu
The device probe method e1000_probe calls e1000_init_eeprom_params itself so there's no reason to call it again from e1000_do_write_eeprom or e1000_do_read_eeprom. The sentence above assumes that e1000_init_eeprom_params is effective but it's mostly dependant on "hw->mac_type": safe as e1000_probe