RE: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters.

2019-07-02 Thread Sudarsana Reddy Kalluru
019 10:19 PM > > To: Parav Pandit > > Cc: Sudarsana Reddy Kalluru ; > > da...@davemloft.net; netdev@vger.kernel.org; > mkalde...@marvell.com; > > ael...@marvell.com; j...@resnulli.us > > Subject: Re: [PATCH net-next 1/1] devlink: Add APIs to > > publish/unpubl

RE: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters.

2019-07-02 Thread Parav Pandit
CH net-next 1/1] devlink: Add APIs to publish/unpublish the > port parameters. > > > A vendor driver calling these APIs is needed at minimum. > > Not a vendor driver, but a mainline driver. > My apologies for terminology. I meant to say that a NIC/hw driver from the kernel tr

Re: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters.

2019-07-02 Thread Andrew Lunn
> A vendor driver calling these APIs is needed at minimum. Not a vendor driver, but a mainline driver. But yes, a new API should not be added without at least one user. Andrew

RE: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters.

2019-07-02 Thread Parav Pandit
ulli.us > Subject: Re: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the > port parameters. > > On Tue, Jul 02, 2019 at 08:20:56AM -0700, Sudarsana Reddy Kalluru wrote: > > The patch adds devlink interfaces for drivers to publish/unpublish the > > devlink port par

Re: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters.

2019-07-02 Thread Andrew Lunn
On Tue, Jul 02, 2019 at 08:20:56AM -0700, Sudarsana Reddy Kalluru wrote: > The patch adds devlink interfaces for drivers to publish/unpublish the > devlink port parameters. Hi Sudarsana A good commit message says more about 'why' than 'what'. I can see the 'what' by reading the code. But the 'why

[PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters.

2019-07-02 Thread Sudarsana Reddy Kalluru
The patch adds devlink interfaces for drivers to publish/unpublish the devlink port parameters. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- include/net/devlink.h | 2 ++ net/core/devlink.c| 42 ++ 2 files changed, 44 inserti