Re: [PATCH net-next 09/12] net: ethernet: Add helper for MACs which support pause

2018-09-03 Thread Andrew Lunn
On Mon, Sep 03, 2018 at 10:39:04AM -0700, Florian Fainelli wrote: > > > On 9/2/2018 10:06 AM, Andrew Lunn wrote: > >Rather than have the MAC drivers manipulate phydev members, add a > >helper function for MACs supporting Pause, but not Asym Pause. > > > >Signed-off-by: Andrew Lunn > > Reviewed-

Re: [PATCH net-next 09/12] net: ethernet: Add helper for MACs which support pause

2018-09-03 Thread Florian Fainelli
On 9/2/2018 10:06 AM, Andrew Lunn wrote: Rather than have the MAC drivers manipulate phydev members, add a helper function for MACs supporting Pause, but not Asym Pause. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli I wonder if this would be better named phy_support_sym_pause(

[PATCH net-next 09/12] net: ethernet: Add helper for MACs which support pause

2018-09-02 Thread Andrew Lunn
Rather than have the MAC drivers manipulate phydev members, add a helper function for MACs supporting Pause, but not Asym Pause. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- drivers/net/ethernet/freescale/fec_main.c| 4 +--- drivers/net/phy/phy_device