Re: [EXT] [PATCH net-next 06/16] qlge: Remove useless dma synchronization calls

2019-06-17 Thread Benjamin Poirier
On 2019/06/17 09:44, Manish Chopra wrote: [...] > > --- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c > > +++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c > > @@ -1110,9 +1110,6 @@ static void ql_update_lbq(struct ql_adapter *qdev, > > struct rx_ring *rx_ring) > > dma_unmap_a

RE: [EXT] [PATCH net-next 06/16] qlge: Remove useless dma synchronization calls

2019-06-17 Thread Manish Chopra
> -Original Message- > From: Benjamin Poirier > Sent: Monday, June 17, 2019 1:19 PM > To: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: [EXT] [PATCH net-next 06/16] qlge: Remove useless dma > synchronization call

[PATCH net-next 06/16] qlge: Remove useless dma synchronization calls

2019-06-17 Thread Benjamin Poirier
This is unneeded for two reasons: 1) the mapping is not written by the cpu 2) calls like ..._sync_..._for_device(..., ..._FROMDEVICE) are nonsensical, see commit 3f0fb4e85b38 ("Documentation/DMA-API-HOWTO.txt: fix misleading example") Signed-off-by: Benjamin Poirier --- drivers/net/etherne