Re: [PATCH net-next 05/18] rtnetlink: Add RTNH_F_TRAP flag

2020-11-09 Thread Ido Schimmel
On Fri, Nov 06, 2020 at 11:12:21AM -0800, Jakub Kicinski wrote: > On Wed, 4 Nov 2020 15:30:27 +0200 Ido Schimmel wrote: > > *flags |= (nhc->nhc_flags & RTNH_F_ONLINK); > > if (nhc->nhc_flags & RTNH_F_OFFLOAD) > > *flags |= RTNH_F_OFFLOAD; > > + if (nhc->nhc_flags & RTNH_F_TRA

Re: [PATCH net-next 05/18] rtnetlink: Add RTNH_F_TRAP flag

2020-11-06 Thread Jakub Kicinski
On Wed, 4 Nov 2020 15:30:27 +0200 Ido Schimmel wrote: > *flags |= (nhc->nhc_flags & RTNH_F_ONLINK); > if (nhc->nhc_flags & RTNH_F_OFFLOAD) > *flags |= RTNH_F_OFFLOAD; > + if (nhc->nhc_flags & RTNH_F_TRAP) > + *flags |= RTNH_F_TRAP; Out of curiosity - why

[PATCH net-next 05/18] rtnetlink: Add RTNH_F_TRAP flag

2020-11-04 Thread Ido Schimmel
From: Ido Schimmel The flag indicates to user space that the nexthop is not programmed to forward packets in hardware, but rather to trap them to the CPU. This is needed, for example, when the MAC of the nexthop neighbour is not resolved and packets should reach the CPU to trigger neighbour resol