Re: [PATCH net-next 05/12] ptr_ring: disallow lockless __ptr_ring_full

2018-01-28 Thread Jason Wang
On 2018年01月29日 12:41, Michael S. Tsirkin wrote: On Mon, Jan 29, 2018 at 11:36:09AM +0800, Jason Wang wrote: On 2018年01月26日 10:46, Michael S. Tsirkin wrote: On 2018年01月26日 07:36, Michael S. Tsirkin wrote: Similar to bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can overrun array

Re: [PATCH net-next 05/12] ptr_ring: disallow lockless __ptr_ring_full

2018-01-28 Thread Michael S. Tsirkin
On Mon, Jan 29, 2018 at 11:36:09AM +0800, Jason Wang wrote: > > > On 2018年01月26日 10:46, Michael S. Tsirkin wrote: > > > On 2018年01月26日 07:36, Michael S. Tsirkin wrote: > > > > Similar to bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can > > > > overrun array bounds") a lockless use of

Re: [PATCH net-next 05/12] ptr_ring: disallow lockless __ptr_ring_full

2018-01-28 Thread Jason Wang
On 2018年01月26日 10:46, Michael S. Tsirkin wrote: On 2018年01月26日 07:36, Michael S. Tsirkin wrote: Similar to bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can overrun array bounds") a lockless use of __ptr_ring_full might cause an out of bounds access. We can fix this, but it's easi

Re: [PATCH net-next 05/12] ptr_ring: disallow lockless __ptr_ring_full

2018-01-25 Thread Michael S. Tsirkin
On Fri, Jan 26, 2018 at 10:38:05AM +0800, Jason Wang wrote: > > > On 2018年01月26日 07:36, Michael S. Tsirkin wrote: > > Similar to bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can > > overrun array bounds") a lockless use of __ptr_ring_full might > > cause an out of bounds access. > >

Re: [PATCH net-next 05/12] ptr_ring: disallow lockless __ptr_ring_full

2018-01-25 Thread Jason Wang
On 2018年01月26日 07:36, Michael S. Tsirkin wrote: Similar to bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can overrun array bounds") a lockless use of __ptr_ring_full might cause an out of bounds access. We can fix this, but it's easier to just disallow lockless __ptr_ring_full for

[PATCH net-next 05/12] ptr_ring: disallow lockless __ptr_ring_full

2018-01-25 Thread Michael S. Tsirkin
Similar to bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can overrun array bounds") a lockless use of __ptr_ring_full might cause an out of bounds access. We can fix this, but it's easier to just disallow lockless __ptr_ring_full for now. Signed-off-by: Michael S. Tsirkin --- includ