Re: [PATCH net-next 03/11] vxlan: Allow configuration of DF behaviour

2018-11-07 Thread Stefano Brivio
Stephen, thanks for reviewing this. On Tue, 6 Nov 2018 21:00:18 -0800 Stephen Hemminger wrote: > On Tue, 6 Nov 2018 22:38:59 +0100 > Stefano Brivio wrote: > > > df = htons(IP_DF); > > } > > > > + if (!df) { > > + if (vxlan->cfg.df

Re: [PATCH net-next 03/11] vxlan: Allow configuration of DF behaviour

2018-11-06 Thread Stephen Hemminger
On Tue, 6 Nov 2018 22:38:59 +0100 Stefano Brivio wrote: > df = htons(IP_DF); > } > > + if (!df) { > + if (vxlan->cfg.df == VXLAN_DF_SET) { > + df = htons(IP_DF); I am confused, this looks like this

[PATCH net-next 03/11] vxlan: Allow configuration of DF behaviour

2018-11-06 Thread Stefano Brivio
Allow users to set the IPv4 DF bit in outgoing packets, or to inherit its value from the IPv4 inner header. If the encapsulated protocol is IPv6 and DF is configured to be inherited, always set it. For IPv4, inheriting DF from the inner header was probably intended from the very beginning judging