On Wed, 2017-06-14 at 12:14 -0700, Stephen Hemminger wrote:
>
> > I just copied it from skb_put() - you could ask the same there? :)
>
> My taste is to have less casts. Never understood why so many skb_
> functions returned char *, probably a leftover from older Unix style.
I agree, for many of
On Wed, 14 Jun 2017 21:01:32 +0200
Johannes Berg wrote:
> On Wed, 2017-06-14 at 08:44 -0700, Stephen Hemminger wrote:
> >
> > > memcpy(skb_put(skb, sizeof(ra)), ra, sizeof(ra));
> > >
> > > - hdr = (struct mld_msg *) skb_put(skb, sizeof(struct
> > > mld_msg));
> > > - memset(hdr, 0, sizeof
On Wed, 2017-06-14 at 08:44 -0700, Stephen Hemminger wrote:
>
> > memcpy(skb_put(skb, sizeof(ra)), ra, sizeof(ra));
> >
> > - hdr = (struct mld_msg *) skb_put(skb, sizeof(struct
> > mld_msg));
> > - memset(hdr, 0, sizeof(struct mld_msg));
> > + hdr = (struct mld_msg *) skb_put_zero(skb
On Wed, 14 Jun 2017 22:37:06 +0800
yuan linyu wrote:
> From: yuan linyu
>
> Signed-off-by: yuan linyu
> ---
> net/ipv6/mcast.c | 3 +--
> net/ipv6/ndisc.c | 13 ++---
> 2 files changed, 3 insertions(+), 13 deletions(-)
>
> diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
> index 074
From: yuan linyu
Signed-off-by: yuan linyu
---
net/ipv6/mcast.c | 3 +--
net/ipv6/ndisc.c | 13 ++---
2 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index 07403fa..b186c67 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -2008
