Re: [PATCH net-next 01/10] tcp: add tp->tcp_mstamp field

2017-04-25 Thread Eric Dumazet
On Tue, Apr 25, 2017 at 2:27 PM, Yuchung Cheng wrote: >> + struct skb_mstamp tcp_mstamp; /* most recent packet received/sent */ > Eric: would this new stamp cover outgoing packet as well in the > future? in the patch series seem to cover only the incoming packets. This is the plan yes : t

Re: [PATCH net-next 01/10] tcp: add tp->tcp_mstamp field

2017-04-25 Thread Yuchung Cheng
On Tue, Apr 25, 2017 at 10:15 AM, Eric Dumazet wrote: > We want to use precise timestamps in TCP stack, but we do not > want to call possibly expensive kernel time services too often. > > tp->tcp_mstamp is guaranteed to be updated once per incoming packet. > > We will use it in the following patch

Re: [PATCH net-next 01/10] tcp: add tp->tcp_mstamp field

2017-04-25 Thread Neal Cardwell
On Tue, Apr 25, 2017 at 1:15 PM, Eric Dumazet wrote: > We want to use precise timestamps in TCP stack, but we do not > want to call possibly expensive kernel time services too often. > > tp->tcp_mstamp is guaranteed to be updated once per incoming packet. > > We will use it in the following patche

Re: [PATCH net-next 01/10] tcp: add tp->tcp_mstamp field

2017-04-25 Thread Soheil Hassas Yeganeh
On Tue, Apr 25, 2017 at 1:15 PM, Eric Dumazet wrote: > We want to use precise timestamps in TCP stack, but we do not > want to call possibly expensive kernel time services too often. > > tp->tcp_mstamp is guaranteed to be updated once per incoming packet. > > We will use it in the following patche

[PATCH net-next 01/10] tcp: add tp->tcp_mstamp field

2017-04-25 Thread Eric Dumazet
We want to use precise timestamps in TCP stack, but we do not want to call possibly expensive kernel time services too often. tp->tcp_mstamp is guaranteed to be updated once per incoming packet. We will use it in the following patches, removing specific skb_mstamp_get() calls, and removing ack_ti