Re: [PATCH net-next 01/10] bnxt_en: Refactor rx SKB function.

2017-01-31 Thread David Miller
From: Michael Chan Date: Mon, 30 Jan 2017 20:49:26 -0500 > @@ -776,7 +778,7 @@ static struct sk_buff *bnxt_rx_skb(struct bnxt *bp, > } > > skb_reserve(skb, BNXT_RX_OFFSET); > - skb_put(skb, len); > + skb_put(skb, len & 0x); > return skb; > } > Like Jakub I wond

Re: [PATCH net-next 01/10] bnxt_en: Refactor rx SKB function.

2017-01-30 Thread Jakub Kicinski
On Mon, 30 Jan 2017 20:49:26 -0500, Michael Chan wrote: > @@ -776,7 +778,7 @@ static struct sk_buff *bnxt_rx_skb(struct bnxt *bp, > } > > skb_reserve(skb, BNXT_RX_OFFSET); > - skb_put(skb, len); > + skb_put(skb, len & 0x); > return skb; > } Looks unrelated?

[PATCH net-next 01/10] bnxt_en: Refactor rx SKB function.

2017-01-30 Thread Michael Chan
Minor refactoring of bnxt_rx_skb() so that it can easily be replaced by a new function that handles packets in a single page. Also, use a function pointer bp->rx_skb_func() to switch to a new function when we add the new mode in the next patch. Add a new field data_ptr that points to the packet d