Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

2019-08-03 Thread David Miller
From: David Ahern Date: Thu, 1 Aug 2019 11:56:33 -0700 > From: David Ahern > > This is a port the functional test cases created during the development > of the VRF feature. It covers various permutations of icmp, tcp and udp > for IPv4 and IPv6 including negative tests. Series applied, thanks

Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

2019-08-02 Thread David Ahern
On 8/2/19 9:15 AM, Alexei Starovoitov wrote: > On Thu, Aug 1, 2019 at 9:11 PM David Ahern wrote: >> >> On 8/1/19 6:19 PM, Alexei Starovoitov wrote: >>> Do you really need 'sleep 1' everywhere? >>> It makes them so slow to run... >>> What happens if you just remove it ? Tests will fail? Why? >> >>

Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

2019-08-02 Thread David Ahern
On 8/2/19 9:14 AM, Alexei Starovoitov wrote: > On Thu, Aug 1, 2019 at 9:04 PM David Ahern wrote: >> ... >> >>> >>> with -v I see: >>> COMMAND: ip netns exec ns-A ping -c1 -w1 -I 172.16.2.1 172.16.1.2 >>> ping: unknown iface 172.16.2.1 >>> TEST: ping out, address bind - ns-B IP

Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

2019-08-02 Thread Alexei Starovoitov
On Thu, Aug 1, 2019 at 9:11 PM David Ahern wrote: > > On 8/1/19 6:19 PM, Alexei Starovoitov wrote: > > Do you really need 'sleep 1' everywhere? > > It makes them so slow to run... > > What happens if you just remove it ? Tests will fail? Why? > > yes, the sleep 1 is needed. A server process is get

Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

2019-08-02 Thread Alexei Starovoitov
On Thu, Aug 1, 2019 at 9:04 PM David Ahern wrote: > ... > > > > > with -v I see: > > COMMAND: ip netns exec ns-A ping -c1 -w1 -I 172.16.2.1 172.16.1.2 > > ping: unknown iface 172.16.2.1 > > TEST: ping out, address bind - ns-B IP > > [FAIL] > > With ping from

Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

2019-08-01 Thread David Ahern
On 8/1/19 6:19 PM, Alexei Starovoitov wrote: > Do you really need 'sleep 1' everywhere? > It makes them so slow to run... > What happens if you just remove it ? Tests will fail? Why? yes, the sleep 1 is needed. A server process is getting launched into the background. It's status is not relevant;

Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

2019-08-01 Thread David Ahern
On 8/1/19 6:19 PM, Alexei Starovoitov wrote: > On Thu, Aug 01, 2019 at 11:56:33AM -0700, David Ahern wrote: >> From: David Ahern >> >> This is a port the functional test cases created during the development >> of the VRF feature. It covers various permutations of icmp, tcp and udp >> for IPv4 and

Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

2019-08-01 Thread Alexei Starovoitov
On Thu, Aug 01, 2019 at 11:56:33AM -0700, David Ahern wrote: > From: David Ahern > > This is a port the functional test cases created during the development > of the VRF feature. It covers various permutations of icmp, tcp and udp > for IPv4 and IPv6 including negative tests. Thanks a lot for do

[PATCH net-next 00/15] net: Add functional tests for L3 and L4

2019-08-01 Thread David Ahern
From: David Ahern This is a port the functional test cases created during the development of the VRF feature. It covers various permutations of icmp, tcp and udp for IPv4 and IPv6 including negative tests. David Ahern (15): selftests: Add nettest selftests: Setup for functional tests for fib