Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-09 Thread Toke Høiland-Jørgensen
Ido Schimmel writes: > On Fri, Aug 09, 2019 at 10:41:47AM +0200, Toke Høiland-Jørgensen wrote: >> This is great. Are you planning to add the XDP integration as well? :) > > Thanks, Toke. From one of your previous replies I got the impression > that another hook needs to be added in order to catch

Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-09 Thread Ido Schimmel
On Fri, Aug 09, 2019 at 10:41:47AM +0200, Toke Høiland-Jørgensen wrote: > This is great. Are you planning to add the XDP integration as well? :) Thanks, Toke. From one of your previous replies I got the impression that another hook needs to be added in order to catch 'XDP_DROP' as it is not covere

Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-09 Thread Ido Schimmel
On Thu, Aug 08, 2019 at 03:08:25PM -0600, David Ahern wrote: > On top of your dropwatch changes I added the ability to print the > payload as hex. e.g., > > Issue Ctrl-C to stop monitoring > drop at: nf_hook_slow+0x59/0x98 (0x814ec532) > input port ifindex: 1 > timestamp: Thu Aug 8 15:04:

Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-09 Thread Toke Høiland-Jørgensen
Ido Schimmel writes: > From: Ido Schimmel > > So far drop monitor supported only one mode of operation in which a > summary of recent packet drops is periodically sent to user space as a > netlink event. The event only includes the drop location (program > counter) and number of drops in the las

Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-08 Thread David Ahern
On 8/7/19 4:30 AM, Ido Schimmel wrote: > Example usage with patched dropwatch [1] can be found here [2]. Example > dissection of drop monitor netlink events with patched wireshark [3] can > be found here [4]. I will submit both changes upstream after the kernel > changes are accepted. Another chang

[PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata

2019-08-07 Thread Ido Schimmel
From: Ido Schimmel So far drop monitor supported only one mode of operation in which a summary of recent packet drops is periodically sent to user space as a netlink event. The event only includes the drop location (program counter) and number of drops in the last interval. While this mode of op