Re: [PATCH net-next 0/9] net: Refactor ip_route_input_slow

2015-09-23 Thread David Ahern
On 9/22/15 11:51 PM, Alexander Duyck wrote: One option you might consider when untangling this is to just return the values instead of leaving any labels. I just did a quick test on my system with gcc version 5.1.1 and going through and just replacing all of the labels with returns actually res

Re: [PATCH net-next 0/9] net: Refactor ip_route_input_slow

2015-09-22 Thread Alexander Duyck
On 09/22/2015 03:55 PM, David Ahern wrote: ip_route_input_slow is a maze of gotos (9 of them!) making it error prone and difficult to read. This patchset refactors it, removing all but 2 of the labels. The brd_input label for broadcast path requires too many inputs to make a reasonble helper out

[PATCH net-next 0/9] net: Refactor ip_route_input_slow

2015-09-22 Thread David Ahern
ip_route_input_slow is a maze of gotos (9 of them!) making it error prone and difficult to read. This patchset refactors it, removing all but 2 of the labels. The brd_input label for broadcast path requires too many inputs to make a reasonble helper out of it so I left it as is. None of these patc