Re: [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-11-13 Thread Willy Tarreau
Hi Alexandre! On Fri, Nov 13, 2020 at 11:03:59AM +0100, Alexandre Belloni wrote: > I think I'm the only one booting recent linux kernels on at91rm9200 and > I'm currently stuck home while the board is at the office. I'll try to > test as soon as possible, which may not be before 2021... At least I

Re: [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-11-13 Thread Alexandre Belloni
On 14/10/2020 05:06:30+0200, Willy Tarreau wrote: > On Tue, Oct 13, 2020 at 05:03:58PM -0700, Jakub Kicinski wrote: > > On Sun, 11 Oct 2020 11:09:41 +0200 Willy Tarreau wrote: > > > while running some tests on my Breadbee board, I noticed poor network > > > Tx performance. I had a look at the drive

Re: [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-10-13 Thread Jakub Kicinski
On Wed, 14 Oct 2020 05:06:30 +0200 Willy Tarreau wrote: > > LGTM. There's always a chance that this will make other > > designs explode, but short of someone from Cadence giving > > us a timely review we have only one way to find that out.. :) > > Not that much in fact, given that the at91ethe

Re: [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-10-13 Thread Willy Tarreau
On Tue, Oct 13, 2020 at 05:03:58PM -0700, Jakub Kicinski wrote: > On Sun, 11 Oct 2020 11:09:41 +0200 Willy Tarreau wrote: > > while running some tests on my Breadbee board, I noticed poor network > > Tx performance. I had a look at the driver (macb, at91ether variant) > > and noticed that at91ether

Re: [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-10-13 Thread Jakub Kicinski
On Sun, 11 Oct 2020 11:09:41 +0200 Willy Tarreau wrote: > while running some tests on my Breadbee board, I noticed poor network > Tx performance. I had a look at the driver (macb, at91ether variant) > and noticed that at91ether_start_xmit() immediately stops the queue > after sending a frame and wa

[PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-10-11 Thread Willy Tarreau
Hi, while running some tests on my Breadbee board, I noticed poor network Tx performance. I had a look at the driver (macb, at91ether variant) and noticed that at91ether_start_xmit() immediately stops the queue after sending a frame and waits for the interrupt to restart the queue, causing a dead