Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-12-28 Thread Jason Wang
On 2017年12月29日 03:11, Willem de Bruijn wrote: On Mon, Oct 16, 2017 at 11:44 PM, Michael S. Tsirkin wrote: On Tue, Oct 17, 2017 at 11:05:07AM +0800, Jason Wang wrote: On 2017年10月17日 06:34, Willem de Bruijn wrote: On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin wrote: On Mon, Oct 16,

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-12-28 Thread Willem de Bruijn
On Mon, Oct 16, 2017 at 11:44 PM, Michael S. Tsirkin wrote: > On Tue, Oct 17, 2017 at 11:05:07AM +0800, Jason Wang wrote: >> >> >> On 2017年10月17日 06:34, Willem de Bruijn wrote: >> > On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin >> > wrote: >> > > On Mon, Oct 16, 2017 at 12:04:57PM -0400,

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-16 Thread Michael S. Tsirkin
On Tue, Oct 17, 2017 at 11:05:07AM +0800, Jason Wang wrote: > > > On 2017年10月17日 06:34, Willem de Bruijn wrote: > > On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin > > wrote: > > > On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: > > > > On Mon, Oct 16, 2017 at 11:31 AM, M

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-16 Thread Jason Wang
On 2017年10月17日 06:34, Willem de Bruijn wrote: On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin wrote: On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin wrote: On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-16 Thread Willem de Bruijn
On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin wrote: > On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: >> On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin wrote: >> > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: >> >> >> +static int virtnet_reset(

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-16 Thread Michael S. Tsirkin
On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: > On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin wrote: > > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: > >> >> +static int virtnet_reset(struct virtnet_info *vi) > >> >> +{ > >> >> + struct virtio_de

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-16 Thread Willem de Bruijn
On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin wrote: > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: >> >> +static int virtnet_reset(struct virtnet_info *vi) >> >> +{ >> >> + struct virtio_device *dev = vi->vdev; >> >> + int ret; >> >> + >> >> + virtio_config

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-16 Thread Michael S. Tsirkin
On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: > >> +static int virtnet_reset(struct virtnet_info *vi) > >> +{ > >> + struct virtio_device *dev = vi->vdev; > >> + int ret; > >> + > >> + virtio_config_disable(dev); > >> + dev->failed = dev->config->get_status(dev)

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-16 Thread Willem de Bruijn
>> +static int virtnet_reset(struct virtnet_info *vi) >> +{ >> + struct virtio_device *dev = vi->vdev; >> + int ret; >> + >> + virtio_config_disable(dev); >> + dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; >> + virtnet_freeze_down(dev, true); >> + remo

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-14 Thread Michael S. Tsirkin
On Fri, Oct 13, 2017 at 11:51:40AM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Implement the reset communication request defined in the VIRTIO 1.0 > specification and introduces in Linux in commit c00bbcf862896 ("virtio: > add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). > >

[PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-13 Thread Willem de Bruijn
From: Willem de Bruijn Implement the reset communication request defined in the VIRTIO 1.0 specification and introduces in Linux in commit c00bbcf862896 ("virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). Use the virtnet_reset function introduced in commit 2de2f7f40ef9 ("virtio_net: X