Re: [PATCH net-next] virtio_net: handle non-napi callers to virtnet_poll_tx

2020-10-10 Thread Jakub Kicinski
On Thu, 8 Oct 2020 11:34:36 -0700 Jonathan Lemon wrote: > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 21b71148c532..59f65ac9e4c7 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1518,7 +1518,7 @@ static int virtnet_poll_tx(struct napi_struc

Re: [PATCH net-next] virtio_net: handle non-napi callers to virtnet_poll_tx

2020-10-08 Thread Jonathan Lemon
On Thu, Oct 08, 2020 at 12:01:02PM -0700, Jakub Kicinski wrote: > On Thu, 8 Oct 2020 11:34:36 -0700 Jonathan Lemon wrote: > > From: Jonathan Lemon > > > > netcons will call napi_poll with a budget of 0, indicating > > a non-napi caller (and also called with irqs disabled). Call > > free_old_xmit

Re: [PATCH net-next] virtio_net: handle non-napi callers to virtnet_poll_tx

2020-10-08 Thread Jakub Kicinski
On Thu, 8 Oct 2020 11:34:36 -0700 Jonathan Lemon wrote: > From: Jonathan Lemon > > netcons will call napi_poll with a budget of 0, indicating > a non-napi caller (and also called with irqs disabled). Call > free_old_xmit_skbs() with the is_napi parameter set correctly. This is a fix, can we get

[PATCH net-next] virtio_net: handle non-napi callers to virtnet_poll_tx

2020-10-08 Thread Jonathan Lemon
From: Jonathan Lemon netcons will call napi_poll with a budget of 0, indicating a non-napi caller (and also called with irqs disabled). Call free_old_xmit_skbs() with the is_napi parameter set correctly. Found by this splat: WARNING: CPU: 2 PID: 1368 at net/core/skbuff.c:650 skb_release_head_