Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-27 Thread Jason Wang
On 2018年09月27日 21:53, Willem de Bruijn wrote: On Thu, Sep 27, 2018 at 4:51 AM Jason Wang wrote: On 2018年09月14日 12:46, Willem de Bruijn wrote: I'm not sure I get this. If we don't enable tx napi, we tend to delay TX interrupt if we found the ring is about to full to avoid interrupt storm,

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-27 Thread Willem de Bruijn
On Thu, Sep 27, 2018 at 4:51 AM Jason Wang wrote: > > > > On 2018年09月14日 12:46, Willem de Bruijn wrote: > >> I'm not sure I get this. If we don't enable tx napi, we tend to delay TX > >> interrupt if we found the ring is about to full to avoid interrupt > >> storm, so we're probably ok in this cas

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-27 Thread Jason Wang
On 2018年09月14日 12:46, Willem de Bruijn wrote: I'm not sure I get this. If we don't enable tx napi, we tend to delay TX interrupt if we found the ring is about to full to avoid interrupt storm, so we're probably ok in this case. I'm only concerned about the transition state when converting fro

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-14 Thread Jason Wang
On 2018年09月14日 12:46, Willem de Bruijn wrote: On Thu, Sep 13, 2018 at 11:53 PM Jason Wang wrote: On 2018年09月14日 11:40, Willem de Bruijn wrote: On Thu, Sep 13, 2018 at 11:27 PM Jason Wang wrote: On 2018年09月13日 22:58, Willem de Bruijn wrote: On Thu, Sep 13, 2018 at 5:02 AM Jason Wang w

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-13 Thread Willem de Bruijn
On Thu, Sep 13, 2018 at 11:53 PM Jason Wang wrote: > > > > On 2018年09月14日 11:40, Willem de Bruijn wrote: > > On Thu, Sep 13, 2018 at 11:27 PM Jason Wang wrote: > >> > >> > >> On 2018年09月13日 22:58, Willem de Bruijn wrote: > >>> On Thu, Sep 13, 2018 at 5:02 AM Jason Wang wrote: > > On 20

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-13 Thread Jason Wang
On 2018年09月14日 11:40, Willem de Bruijn wrote: On Thu, Sep 13, 2018 at 11:27 PM Jason Wang wrote: On 2018年09月13日 22:58, Willem de Bruijn wrote: On Thu, Sep 13, 2018 at 5:02 AM Jason Wang wrote: On 2018年09月13日 07:27, Willem de Bruijn wrote: On Wed, Sep 12, 2018 at 3:11 PM Willem de Brui

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-13 Thread Willem de Bruijn
On Thu, Sep 13, 2018 at 11:27 PM Jason Wang wrote: > > > > On 2018年09月13日 22:58, Willem de Bruijn wrote: > > On Thu, Sep 13, 2018 at 5:02 AM Jason Wang wrote: > >> > >> > >> On 2018年09月13日 07:27, Willem de Bruijn wrote: > >>> On Wed, Sep 12, 2018 at 3:11 PM Willem de Bruijn > >>> wrote: > O

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-13 Thread Jason Wang
On 2018年09月13日 22:58, Willem de Bruijn wrote: On Thu, Sep 13, 2018 at 5:02 AM Jason Wang wrote: On 2018年09月13日 07:27, Willem de Bruijn wrote: On Wed, Sep 12, 2018 at 3:11 PM Willem de Bruijn wrote: On Wed, Sep 12, 2018 at 2:16 PM Florian Fainelli wrote: On 9/12/2018 11:07 AM, Willem

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-13 Thread Willem de Bruijn
On Thu, Sep 13, 2018 at 5:02 AM Jason Wang wrote: > > > > On 2018年09月13日 07:27, Willem de Bruijn wrote: > > On Wed, Sep 12, 2018 at 3:11 PM Willem de Bruijn > > wrote: > >> On Wed, Sep 12, 2018 at 2:16 PM Florian Fainelli > >> wrote: > >>> > >>> > >>> On 9/12/2018 11:07 AM, Willem de Bruijn wro

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-13 Thread Jason Wang
On 2018年09月12日 21:43, Willem de Bruijn wrote: On Tue, Sep 11, 2018 at 11:35 PM Jason Wang wrote: On 2018年09月11日 09:14, Willem de Bruijn wrote: I cook a fixup, and it looks works in my setup: diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index b320b6b14749..9181c3f2f832

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-13 Thread Jason Wang
On 2018年09月13日 03:11, Willem de Bruijn wrote: On Wed, Sep 12, 2018 at 2:16 PM Florian Fainelli wrote: On 9/12/2018 11:07 AM, Willem de Bruijn wrote: On Wed, Sep 12, 2018 at 1:42 PM Florian Fainelli wrote: On 9/9/2018 3:44 PM, Willem de Bruijn wrote: From: Willem de Bruijn Implement

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-13 Thread Jason Wang
On 2018年09月13日 07:27, Willem de Bruijn wrote: On Wed, Sep 12, 2018 at 3:11 PM Willem de Bruijn wrote: On Wed, Sep 12, 2018 at 2:16 PM Florian Fainelli wrote: On 9/12/2018 11:07 AM, Willem de Bruijn wrote: On Wed, Sep 12, 2018 at 1:42 PM Florian Fainelli wrote: On 9/9/2018 3:44 PM, W

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-12 Thread Willem de Bruijn
On Wed, Sep 12, 2018 at 3:11 PM Willem de Bruijn wrote: > > On Wed, Sep 12, 2018 at 2:16 PM Florian Fainelli wrote: > > > > > > > > On 9/12/2018 11:07 AM, Willem de Bruijn wrote: > > > On Wed, Sep 12, 2018 at 1:42 PM Florian Fainelli > > > wrote: > > >> > > >> > > >> > > >> On 9/9/2018 3:44 PM,

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-12 Thread Willem de Bruijn
On Wed, Sep 12, 2018 at 2:16 PM Florian Fainelli wrote: > > > > On 9/12/2018 11:07 AM, Willem de Bruijn wrote: > > On Wed, Sep 12, 2018 at 1:42 PM Florian Fainelli > > wrote: > >> > >> > >> > >> On 9/9/2018 3:44 PM, Willem de Bruijn wrote: > >>> From: Willem de Bruijn > >>> > >>> Implement etht

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-12 Thread Florian Fainelli
On 9/12/2018 11:07 AM, Willem de Bruijn wrote: On Wed, Sep 12, 2018 at 1:42 PM Florian Fainelli wrote: On 9/9/2018 3:44 PM, Willem de Bruijn wrote: From: Willem de Bruijn Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. Interrupt moderation is currently not support

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-12 Thread Willem de Bruijn
On Wed, Sep 12, 2018 at 1:42 PM Florian Fainelli wrote: > > > > On 9/9/2018 3:44 PM, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. > > Interrupt moderation is currently not supported, so these accept and > > displa

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-12 Thread Florian Fainelli
On 9/9/2018 3:44 PM, Willem de Bruijn wrote: From: Willem de Bruijn Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. Interrupt moderation is currently not supported, so these accept and display the default settings of 0 usec and 1 frame. Toggle tx napi through a bit in

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-12 Thread Willem de Bruijn
On Tue, Sep 11, 2018 at 11:35 PM Jason Wang wrote: > > > > On 2018年09月11日 09:14, Willem de Bruijn wrote: > I cook a fixup, and it looks works in my setup: > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index b320b6b14749..9181c3f2f832 100644 > --- a

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-11 Thread Jason Wang
On 2018年09月11日 09:14, Willem de Bruijn wrote: I cook a fixup, and it looks works in my setup: diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index b320b6b14749..9181c3f2f832 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2204,10 +2204,17 @@ static i

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-10 Thread Willem de Bruijn
> >> I cook a fixup, and it looks works in my setup: > >> > >> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > >> index b320b6b14749..9181c3f2f832 100644 > >> --- a/drivers/net/virtio_net.c > >> +++ b/drivers/net/virtio_net.c > >> @@ -2204,10 +2204,17 @@ static int virtnet_set_co

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-10 Thread Jason Wang
On 2018年09月10日 21:35, Willem de Bruijn wrote: On Mon, Sep 10, 2018 at 2:01 AM Jason Wang wrote: On 2018年09月10日 06:44, Willem de Bruijn wrote: From: Willem de Bruijn Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. Interrupt moderation is currently not supported, so

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-10 Thread Willem de Bruijn
On Mon, Sep 10, 2018 at 2:01 AM Jason Wang wrote: > > > > On 2018年09月10日 06:44, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. > > Interrupt moderation is currently not supported, so these accept and > > display the

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-09 Thread Jason Wang
On 2018年09月10日 06:44, Willem de Bruijn wrote: From: Willem de Bruijn Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. Interrupt moderation is currently not supported, so these accept and display the default settings of 0 usec and 1 frame. Toggle tx napi through a bit in

[PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-09 Thread Willem de Bruijn
From: Willem de Bruijn Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. Interrupt moderation is currently not supported, so these accept and display the default settings of 0 usec and 1 frame. Toggle tx napi through a bit in tx-frames. So as to not interfere with possible fu