Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-06-10 Thread Jason Xing
On Tue, Jun 11, 2024 at 1:57 AM Jakub Kicinski wrote: > > On Sat, 8 Jun 2024 08:41:44 +0800 Jason Xing wrote: > > > > Sorry to revive this thread. I wonder why not use this patch like mlnx > > > > driver > > > > does instead of adding statistics into the yaml file? Are we gradually > > > > using

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-06-10 Thread Jakub Kicinski
On Sat, 8 Jun 2024 08:41:44 +0800 Jason Xing wrote: > > > Sorry to revive this thread. I wonder why not use this patch like mlnx > > > driver > > > does instead of adding statistics into the yaml file? Are we gradually > > > using or > > > adding more fields into the yaml file to replace the 'eth

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-06-07 Thread Jason Xing
aba.com; virtualizat...@lists.linux.dev; > > da...@davemloft.net; eduma...@google.com; ab...@redhat.com; Parav > > Pandit > > Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters > > > > On Sat, Feb 3, 2024 at 12:46 AM Daniel Jurgens wrote: > > >

RE: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-06-07 Thread Dan Jurgens
...@redhat.com; Parav > Pandit > Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters > > On Sat, Feb 3, 2024 at 12:46 AM Daniel Jurgens wrote: > > > > > From: Jakub Kicinski > > > Sent: Friday, February 2, 2024 10:01 AM > > &

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-06-07 Thread Jason Xing
On Sat, Feb 3, 2024 at 12:46 AM Daniel Jurgens wrote: > > > From: Jakub Kicinski > > Sent: Friday, February 2, 2024 10:01 AM > > Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters > > > > On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wro

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-20 Thread Jakub Kicinski
On Tue, 20 Feb 2024 13:05:46 -0500 Michael S. Tsirkin wrote: > > Michael, are you a NACK on this? Jakub seemed OK with it, Jason > > also thinks it's useful, and it's low risk. > > Not too bad ... Jakub can you confirm though? Ughhm. Let me implement the generic API myself. I should have a few

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-20 Thread Michael S. Tsirkin
.@linux.alibaba.com; > > virtualizat...@lists.linux.dev; da...@davemloft.net; > > eduma...@google.com; ab...@redhat.com; Parav Pandit > > > > Subject: RE: [PATCH net-next] virtio_net: Add TX stop and wake counters > > > > > > > From: Michael S. Tsirkin > &

RE: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-20 Thread Dan Jurgens
le.com; ab...@redhat.com; Parav Pandit > > Subject: RE: [PATCH net-next] virtio_net: Add TX stop and wake counters > > > > From: Michael S. Tsirkin > > Sent: Wednesday, February 7, 2024 2:19 PM > > To: Daniel Jurgens > > Subject: Re: [PATCH net-next] virtio_n

RE: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-07 Thread Daniel Jurgens
> From: Michael S. Tsirkin > Sent: Wednesday, February 7, 2024 2:19 PM > To: Daniel Jurgens > Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters > > On Wed, Feb 07, 2024 at 07:38:16PM +, Daniel Jurgens wrote: > > > From: Michael S. Tsirkin &

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-07 Thread Michael S. Tsirkin
On Mon, Feb 05, 2024 at 09:45:38AM +0800, Jason Wang wrote: > On Sun, Feb 4, 2024 at 8:39 PM Michael S. Tsirkin wrote: > > > > On Sun, Feb 04, 2024 at 09:20:18AM +0800, Jason Wang wrote: > > > On Sat, Feb 3, 2024 at 12:01 AM Jakub Kicinski wrote: > > > > > > > > On Fri, 2 Feb 2024 14:52:59 +0800

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-07 Thread Michael S. Tsirkin
.@linux.alibaba.com; > > virtualizat...@lists.linux.dev; da...@davemloft.net; > > eduma...@google.com; ab...@redhat.com; Parav Pandit > > > > Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters > > > > On Sun, Feb 04, 2024 at 09:20:18AM +0800, Jason

RE: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-07 Thread Daniel Jurgens
ab...@redhat.com; Parav Pandit > > Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters > > On Sun, Feb 04, 2024 at 09:20:18AM +0800, Jason Wang wrote: > > On Sat, Feb 3, 2024 at 12:01 AM Jakub Kicinski wrote: > > > > > > On Fri, 2 Feb 2024

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-04 Thread Jason Wang
On Sun, Feb 4, 2024 at 8:39 PM Michael S. Tsirkin wrote: > > On Sun, Feb 04, 2024 at 09:20:18AM +0800, Jason Wang wrote: > > On Sat, Feb 3, 2024 at 12:01 AM Jakub Kicinski wrote: > > > > > > On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wrote: > > > > > Can you say more? I'm curious what's your us

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-04 Thread Michael S. Tsirkin
On Sun, Feb 04, 2024 at 09:20:18AM +0800, Jason Wang wrote: > On Sat, Feb 3, 2024 at 12:01 AM Jakub Kicinski wrote: > > > > On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wrote: > > > > Can you say more? I'm curious what's your use case. > > > > > > I'm not working at Nvidia, so my point of view may

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-03 Thread Jason Wang
On Sat, Feb 3, 2024 at 12:01 AM Jakub Kicinski wrote: > > On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wrote: > > > Can you say more? I'm curious what's your use case. > > > > I'm not working at Nvidia, so my point of view may differ from theirs. > > From what I can tell is that those two counters

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-02 Thread Jakub Kicinski
On Fri, 2 Feb 2024 16:46:28 + Daniel Jurgens wrote: > > Daniel, I think this may be a good enough excuse to add per-queue stats to > > the netdev genl family, if you're up for that. LMK if you want more info, > > otherwise I guess ethtool -S is fine for now. > > For now, I would like to go w

RE: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-02 Thread Daniel Jurgens
> From: Jakub Kicinski > Sent: Friday, February 2, 2024 10:01 AM > Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters > > On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wrote: > > > Can you say more? I'm curious what's your use case. > &

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-02 Thread Jakub Kicinski
On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wrote: > > Can you say more? I'm curious what's your use case. > > I'm not working at Nvidia, so my point of view may differ from theirs. > From what I can tell is that those two counters help me narrow down > the range if I have to diagnose/debug som

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-01 Thread Jason Xing
On Fri, Feb 2, 2024 at 12:21 PM Jakub Kicinski wrote: > > On Wed, 31 Jan 2024 10:54:33 +0800 Jason Xing wrote: > > > [danielj@sw-mtx-051 upstream]$ ethtool -S ens2f1np1 | grep 'stop\|wake' > > > tx_queue_stopped: 0 > > > tx_queue_wake: 0 > > > tx0_stopped: 0 > > > tx0_wake: 0 >

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-02-01 Thread Jakub Kicinski
On Wed, 31 Jan 2024 10:54:33 +0800 Jason Xing wrote: > > [danielj@sw-mtx-051 upstream]$ ethtool -S ens2f1np1 | grep 'stop\|wake' > > tx_queue_stopped: 0 > > tx_queue_wake: 0 > > tx0_stopped: 0 > > tx0_wake: 0 > > > > Yes, that's it! What I know is that only mlx driv

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Jason Xing
On Wed, Jan 31, 2024 at 1:53 AM Daniel Jurgens wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, January 30, 2024 9:53 AM > > On Tue, Jan 30, 2024 at 03:50:29PM +, Daniel Jurgens wrote: > > > > From: Michael S. Tsirkin > > > > Sent: Tuesday, January 30, 2024 9:42 AM On Tue, Jan 30, 20

RE: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Daniel Jurgens
> From: Michael S. Tsirkin > Sent: Tuesday, January 30, 2024 9:53 AM > On Tue, Jan 30, 2024 at 03:50:29PM +, Daniel Jurgens wrote: > > > From: Michael S. Tsirkin > > > Sent: Tuesday, January 30, 2024 9:42 AM On Tue, Jan 30, 2024 at > > > 03:40:21PM +, Daniel Jurgens wrote: > > > > > From:

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Michael S. Tsirkin
On Tue, Jan 30, 2024 at 03:50:29PM +, Daniel Jurgens wrote: > > From: Michael S. Tsirkin > > Sent: Tuesday, January 30, 2024 9:42 AM > > On Tue, Jan 30, 2024 at 03:40:21PM +, Daniel Jurgens wrote: > > > > From: Michael S. Tsirkin > > > > Sent: Tuesday, January 30, 2024 8:58 AM > > > > > >

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Michael S. Tsirkin
On Tue, Jan 30, 2024 at 03:43:48PM +, Daniel Jurgens wrote: > > From: Heng Qi > > Sent: Tuesday, January 30, 2024 9:17 AM > > 在 2024/1/30 下午10:25, Daniel Jurgens 写道: > > > Add a tx queue stop and wake counters, they are useful for debugging. > > > > > > $ ethtool -S ens5f2 | grep 'tx_stop\|t

RE: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Daniel Jurgens
> From: Michael S. Tsirkin > Sent: Tuesday, January 30, 2024 9:42 AM > On Tue, Jan 30, 2024 at 03:40:21PM +, Daniel Jurgens wrote: > > > From: Michael S. Tsirkin > > > Sent: Tuesday, January 30, 2024 8:58 AM > > > > > > On Tue, Jan 30, 2024 at 08:25:21AM -0600, Daniel Jurgens wrote: > > > > A

RE: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Daniel Jurgens
> From: Heng Qi > Sent: Tuesday, January 30, 2024 9:17 AM > 在 2024/1/30 下午10:25, Daniel Jurgens 写道: > > Add a tx queue stop and wake counters, they are useful for debugging. > > > > $ ethtool -S ens5f2 | grep 'tx_stop\|tx_wake' > > ... > > tx_queue_1_tx_stop: 16726 > > tx_queue_1_t

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Michael S. Tsirkin
On Tue, Jan 30, 2024 at 03:40:21PM +, Daniel Jurgens wrote: > > From: Michael S. Tsirkin > > Sent: Tuesday, January 30, 2024 8:58 AM > > > > On Tue, Jan 30, 2024 at 08:25:21AM -0600, Daniel Jurgens wrote: > > > Add a tx queue stop and wake counters, they are useful for debugging. > > > > > >

RE: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Daniel Jurgens
> From: Michael S. Tsirkin > Sent: Tuesday, January 30, 2024 8:58 AM > > On Tue, Jan 30, 2024 at 08:25:21AM -0600, Daniel Jurgens wrote: > > Add a tx queue stop and wake counters, they are useful for debugging. > > > > $ ethtool -S ens5f2 | grep 'tx_stop\|tx_wake' > > ... > > tx_queue

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Heng Qi
在 2024/1/30 下午10:25, Daniel Jurgens 写道: Add a tx queue stop and wake counters, they are useful for debugging. $ ethtool -S ens5f2 | grep 'tx_stop\|tx_wake' ... tx_queue_1_tx_stop: 16726 tx_queue_1_tx_wake: 16726 ... tx_queue_8_tx_stop: 1500110

Re: [PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Michael S. Tsirkin
On Tue, Jan 30, 2024 at 08:25:21AM -0600, Daniel Jurgens wrote: > Add a tx queue stop and wake counters, they are useful for debugging. > > $ ethtool -S ens5f2 | grep 'tx_stop\|tx_wake' > ... > tx_queue_1_tx_stop: 16726 > tx_queue_1_tx_wake: 16726 > ... > tx_que

[PATCH net-next] virtio_net: Add TX stop and wake counters

2024-01-30 Thread Daniel Jurgens
Add a tx queue stop and wake counters, they are useful for debugging. $ ethtool -S ens5f2 | grep 'tx_stop\|tx_wake' ... tx_queue_1_tx_stop: 16726 tx_queue_1_tx_wake: 16726 ... tx_queue_8_tx_stop: 1500110 tx_queue_8_tx_wake: 1500110 Signed-of