Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-22 Thread Jason Wang
On 2017年02月23日 01:17, John Fastabend wrote: On 17-02-21 12:46 AM, Jason Wang wrote: This patch switch to use build_skb() for small buffer which can have better performance for both TCP and XDP (since we can work at page before skb creation). It also remove lots of XDP codes since both mergeabl

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-22 Thread John Fastabend
On 17-02-21 12:46 AM, Jason Wang wrote: > This patch switch to use build_skb() for small buffer which can have > better performance for both TCP and XDP (since we can work at page > before skb creation). It also remove lots of XDP codes since both > mergeable and small buffer use page frag during r

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-22 Thread Jason Wang
On 2017年02月22日 11:42, Michael S. Tsirkin wrote: On Wed, Feb 22, 2017 at 11:17:50AM +0800, Jason Wang wrote: On 2017年02月22日 11:06, Michael S. Tsirkin wrote: On Wed, Feb 22, 2017 at 10:58:08AM +0800, Jason Wang wrote: On 2017年02月21日 22:37, Michael S. Tsirkin wrote: On Tue, Feb 21, 2017 at 04

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Michael S. Tsirkin
On Wed, Feb 22, 2017 at 11:17:50AM +0800, Jason Wang wrote: > > > On 2017年02月22日 11:06, Michael S. Tsirkin wrote: > > On Wed, Feb 22, 2017 at 10:58:08AM +0800, Jason Wang wrote: > > > > > > On 2017年02月21日 22:37, Michael S. Tsirkin wrote: > > > > On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wa

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Jason Wang
On 2017年02月22日 11:17, Jason Wang wrote: On 2017年02月22日 11:06, Michael S. Tsirkin wrote: On Wed, Feb 22, 2017 at 10:58:08AM +0800, Jason Wang wrote: On 2017年02月21日 22:37, Michael S. Tsirkin wrote: On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wang wrote: This patch switch to use build_s

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Jason Wang
On 2017年02月22日 11:06, Michael S. Tsirkin wrote: On Wed, Feb 22, 2017 at 10:58:08AM +0800, Jason Wang wrote: On 2017年02月21日 22:37, Michael S. Tsirkin wrote: On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wang wrote: This patch switch to use build_skb() for small buffer which can have better

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Michael S. Tsirkin
On Wed, Feb 22, 2017 at 10:58:08AM +0800, Jason Wang wrote: > > > On 2017年02月21日 22:37, Michael S. Tsirkin wrote: > > On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wang wrote: > > > This patch switch to use build_skb() for small buffer which can have > > > better performance for both TCP and XD

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Jason Wang
On 2017年02月21日 22:37, Michael S. Tsirkin wrote: On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wang wrote: This patch switch to use build_skb() for small buffer which can have better performance for both TCP and XDP (since we can work at page before skb creation). It also remove lots of XDP c

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread David Miller
From: Jason Wang Date: Tue, 21 Feb 2017 16:46:28 +0800 > This patch switch to use build_skb() for small buffer which can have > better performance for both TCP and XDP (since we can work at page > before skb creation). It also remove lots of XDP codes since both > mergeable and small buffer use p

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wang wrote: > This patch switch to use build_skb() for small buffer which can have > better performance for both TCP and XDP (since we can work at page > before skb creation). It also remove lots of XDP codes since both > mergeable and small buffer us

[PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Jason Wang
This patch switch to use build_skb() for small buffer which can have better performance for both TCP and XDP (since we can work at page before skb creation). It also remove lots of XDP codes since both mergeable and small buffer use page frag during refill now. Before | Af