Re: [PATCH net-next] virtio-net: on tx, only call napi_disable if tx napi is on

2017-04-26 Thread David Miller
From: Willem de Bruijn Date: Tue, 25 Apr 2017 15:59:17 -0400 > From: Willem de Bruijn > > As of tx napi, device down (`ip link set dev $dev down`) hangs unless > tx napi is enabled. Else napi_enable is not called, so napi_disable > will spin on test_and_set_bit NAPI_STATE_SCHED. > > Only call

Re: [PATCH net-next] virtio-net: on tx, only call napi_disable if tx napi is on

2017-04-25 Thread Jason Wang
On 2017年04月26日 03:59, Willem de Bruijn wrote: From: Willem de Bruijn As of tx napi, device down (`ip link set dev $dev down`) hangs unless tx napi is enabled. Else napi_enable is not called, so napi_disable will spin on test_and_set_bit NAPI_STATE_SCHED. Only call napi_disable if tx napi is

Re: [PATCH net-next] virtio-net: on tx, only call napi_disable if tx napi is on

2017-04-25 Thread Michael S. Tsirkin
On Tue, Apr 25, 2017 at 03:59:17PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > As of tx napi, device down (`ip link set dev $dev down`) hangs unless > tx napi is enabled. Else napi_enable is not called, so napi_disable > will spin on test_and_set_bit NAPI_STATE_SCHED. > > Only ca

[PATCH net-next] virtio-net: on tx, only call napi_disable if tx napi is on

2017-04-25 Thread Willem de Bruijn
From: Willem de Bruijn As of tx napi, device down (`ip link set dev $dev down`) hangs unless tx napi is enabled. Else napi_enable is not called, so napi_disable will spin on test_and_set_bit NAPI_STATE_SCHED. Only call napi_disable if tx napi is enabled. Fixes: 5a719c2552ca ("virtio-net: transm