Re: [PATCH net-next] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Jason Wang
On 2017年12月08日 11:11, Eric Dumazet wrote: On Fri, 2017-12-08 at 10:54 +0800, Jason Wang wrote: Private destructor could be called when register_netdev() fail with rtnl lock held. This will lead deadlock in tun_free_netdev() who tries to hold rtnl_lock. Fixing this by switching to use spinlock

Re: [PATCH net-next] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Eric Dumazet
On Fri, 2017-12-08 at 10:54 +0800, Jason Wang wrote: > Private destructor could be called when register_netdev() fail with > rtnl lock held. This will lead deadlock in tun_free_netdev() who > tries > to hold rtnl_lock. Fixing this by switching to use spinlock to > synchronize. > > Fixes: 96f840616

[PATCH net-next] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Jason Wang
Private destructor could be called when register_netdev() fail with rtnl lock held. This will lead deadlock in tun_free_netdev() who tries to hold rtnl_lock. Fixing this by switching to use spinlock to synchronize. Fixes: 96f84061620c ("tun: add eBPF based queue selection method") Reported-by: Eri