Re: [PATCH net-next] tcp: md5: do not use stack storage in crypto operations

2016-06-27 Thread Eric Dumazet
On Mon, 2016-06-27 at 10:51 -0400, David Miller wrote: > From: Eric Dumazet > Date: Sat, 25 Jun 2016 18:09:35 +0200 > > > From: Eric Dumazet > > > > Some arches have virtually mapped kernel stacks, or will soon have. > > > > tcp_md5_hash_header() uses an automatic variable to copy tcp header >

Re: [PATCH net-next] tcp: md5: do not use stack storage in crypto operations

2016-06-27 Thread Andy Lutomirski
On Mon, Jun 27, 2016 at 7:51 AM, David Miller wrote: > From: Eric Dumazet > Date: Sat, 25 Jun 2016 18:09:35 +0200 > >> From: Eric Dumazet >> >> Some arches have virtually mapped kernel stacks, or will soon have. >> >> tcp_md5_hash_header() uses an automatic variable to copy tcp header >> before

Re: [PATCH net-next] tcp: md5: do not use stack storage in crypto operations

2016-06-27 Thread David Miller
From: Eric Dumazet Date: Sat, 25 Jun 2016 18:09:35 +0200 > From: Eric Dumazet > > Some arches have virtually mapped kernel stacks, or will soon have. > > tcp_md5_hash_header() uses an automatic variable to copy tcp header > before mangling th->check and calling crypto function, which might > b

Re: [PATCH net-next] tcp: md5: do not use stack storage in crypto operations

2016-06-25 Thread Andy Lutomirski
On Sat, Jun 25, 2016 at 9:09 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Some arches have virtually mapped kernel stacks, or will soon have. > > tcp_md5_hash_header() uses an automatic variable to copy tcp header > before mangling th->check and calling crypto function, which might > be probl

[PATCH net-next] tcp: md5: do not use stack storage in crypto operations

2016-06-25 Thread Eric Dumazet
From: Eric Dumazet Some arches have virtually mapped kernel stacks, or will soon have. tcp_md5_hash_header() uses an automatic variable to copy tcp header before mangling th->check and calling crypto function, which might be problematic on such arches. So use percpu storage as we already do for