Re: [PATCH net-next] tcp: defer sacked assignment

2016-08-18 Thread David Miller
From: Eric Dumazet Date: Wed, 17 Aug 2016 07:48:36 -0700 > From: Eric Dumazet > > While chasing tcp_xmit_retransmit_queue() kasan issue, I found > that we could avoid reading sacked field of skb that we wont send, > possibly removing one cache line miss. > > Very minor change in slow path, but

Re: [PATCH net-next] tcp: defer sacked assignment

2016-08-17 Thread Neal Cardwell
On Wed, Aug 17, 2016 at 10:48 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > While chasing tcp_xmit_retransmit_queue() kasan issue, I found > that we could avoid reading sacked field of skb that we wont send, > possibly removing one cache line miss. > > Very minor change in slow path, but why

[PATCH net-next] tcp: defer sacked assignment

2016-08-17 Thread Eric Dumazet
From: Eric Dumazet While chasing tcp_xmit_retransmit_queue() kasan issue, I found that we could avoid reading sacked field of skb that we wont send, possibly removing one cache line miss. Very minor change in slow path, but why not ? ;) Signed-off-by: Eric Dumazet --- net/ipv4/tcp_output.c |