Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread Eric Dumazet
On Thu, 2015-05-21 at 23:25 -0400, David Miller wrote: > From: Eric Dumazet > Date: Wed, 20 May 2015 16:35:41 -0700 > > > From: Marcelo Ricardo Leitner > > > > This patch tracks the total number of inbound and outbound segments on a > > TCP socket. One may use this number to have an idea on con

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread David Miller
From: Eric Dumazet Date: Wed, 20 May 2015 16:35:41 -0700 > From: Marcelo Ricardo Leitner > > This patch tracks the total number of inbound and outbound segments on a > TCP socket. One may use this number to have an idea on connection > quality when compared against the retransmissions. > > RFC

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread Marcelo Ricardo Leitner
On Thu, May 21, 2015 at 12:41:21PM -0700, Yuchung Cheng wrote: > On Wed, May 20, 2015 at 4:35 PM, Eric Dumazet wrote: ... > > diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c > > index > > b6575d6655681e8e84993a5db929c7309d47d4d3..beac6bf840b9a9d1e2f281d2b1c71b5a3414b824 > > 100644 > > ---

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread Eric Dumazet
On Thu, 2015-05-21 at 12:41 -0700, Yuchung Cheng wrote: > It'd be nice to count SYN and SYNACKs for apps tracking the handshake stats. > For syn-cookies we can't do much. But for the rest we can account > req->num_retrans for SYN-ACKs sent, and perhaps track SYN received in > request sock? Well,

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread Yuchung Cheng
On Wed, May 20, 2015 at 4:35 PM, Eric Dumazet wrote: > > From: Marcelo Ricardo Leitner > > This patch tracks the total number of inbound and outbound segments on a > TCP socket. One may use this number to have an idea on connection > quality when compared against the retransmissions. > > RFC4898

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread Marcelo Ricardo Leitner
On Wed, May 20, 2015 at 05:52:34PM -0700, Eric Dumazet wrote: > On Wed, 2015-05-20 at 17:48 -0700, Rick Jones wrote: > > On 05/20/2015 05:37 PM, Eric Dumazet wrote: > > > > > Anyway, if we can send tcp data at 100Gbits on one flow, I guess we are > > > doing a terrific job and do not need to tweak

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-20 Thread Eric Dumazet
On Wed, 2015-05-20 at 17:48 -0700, Rick Jones wrote: > On 05/20/2015 05:37 PM, Eric Dumazet wrote: > > > Anyway, if we can send tcp data at 100Gbits on one flow, I guess we are > > doing a terrific job and do not need to tweak TCP stack anymore ;) > > :) > Note that I have no particular strong

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-20 Thread Rick Jones
On 05/20/2015 05:37 PM, Eric Dumazet wrote: Anyway, if we can send tcp data at 100Gbits on one flow, I guess we are doing a terrific job and do not need to tweak TCP stack anymore ;) :) rick -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to major

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-20 Thread Eric Dumazet
On Wed, 2015-05-20 at 17:06 -0700, Rick Jones wrote: > On 05/20/2015 04:35 PM, Eric Dumazet wrote: > > From: Marcelo Ricardo Leitner > > > > This patch tracks the total number of inbound and outbound segments on a > > TCP socket. One may use this number to have an idea on connection > > quality wh

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-20 Thread Rick Jones
On 05/20/2015 04:35 PM, Eric Dumazet wrote: From: Marcelo Ricardo Leitner This patch tracks the total number of inbound and outbound segments on a TCP socket. One may use this number to have an idea on connection quality when compared against the retransmissions. RFC4898 named these : tcpEStat

[PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-20 Thread Eric Dumazet
From: Marcelo Ricardo Leitner This patch tracks the total number of inbound and outbound segments on a TCP socket. One may use this number to have an idea on connection quality when compared against the retransmissions. RFC4898 named these : tcpEStatsPerfSegsIn and tcpEStatsPerfSegsOut These ar