Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-17 Thread Tom Herbert
On Mon, Oct 17, 2016 at 8:35 PM, Lawrence Brakmo wrote: > Yuchung and Eric, thank you for your comments. > > It looks like I need to think more about this patch. I was trying > to reduce the likelihood of reordering (which seems even more > important based on Eric¹s comment on pacing), but it seem

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-17 Thread Lawrence Brakmo
Yuchung and Eric, thank you for your comments. It looks like I need to think more about this patch. I was trying to reduce the likelihood of reordering (which seems even more important based on Eric¹s comment on pacing), but it seems like the only way to prevent reordering is to only re-hash after

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-12 Thread Eric Dumazet
On Tue, 2016-10-11 at 20:56 -0700, Yuchung Cheng wrote: > I thought more about this patch on my way home and have more > questions: why do we exclude RTO retransmission specifically? also > when we rehash, we'll introduce reordering either in recovery or after > recovery, as some TCP CC like bbr w

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-11 Thread Yuchung Cheng
On Tue, Oct 11, 2016 at 6:01 PM, Yuchung Cheng wrote: > On Tue, Oct 11, 2016 at 2:08 PM, Lawrence Brakmo wrote: >> Yuchung, thank you for your comments. Responses inline. >> >> On 10/11/16, 12:49 PM, "Yuchung Cheng" wrote: >> >>>On Mon, Oct 10, 2016 at 5:18 PM, Lawrence Brakmo wrote:

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-11 Thread Yuchung Cheng
On Tue, Oct 11, 2016 at 2:08 PM, Lawrence Brakmo wrote: > Yuchung, thank you for your comments. Responses inline. > > On 10/11/16, 12:49 PM, "Yuchung Cheng" wrote: > >>On Mon, Oct 10, 2016 at 5:18 PM, Lawrence Brakmo wrote: >>> >>> The purpose of this patch is to help balance flows across paths.

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-11 Thread Lawrence Brakmo
Yuchung, thank you for your comments. Responses inline. On 10/11/16, 12:49 PM, "Yuchung Cheng" wrote: >On Mon, Oct 10, 2016 at 5:18 PM, Lawrence Brakmo wrote: >> >> The purpose of this patch is to help balance flows across paths. A new >> sysctl "tcp_retrans_txhash_prob" specifies the probabili

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-11 Thread Yuchung Cheng
On Mon, Oct 10, 2016 at 5:18 PM, Lawrence Brakmo wrote: > > The purpose of this patch is to help balance flows across paths. A new > sysctl "tcp_retrans_txhash_prob" specifies the probability (0-100) that > the txhash (IPv6 flowlabel) will be changed after a non-RTO retransmit. > A probability is

[PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-10 Thread Lawrence Brakmo
The purpose of this patch is to help balance flows across paths. A new sysctl "tcp_retrans_txhash_prob" specifies the probability (0-100) that the txhash (IPv6 flowlabel) will be changed after a non-RTO retransmit. A probability is used in order to control how many flows are moved during a congesti