Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-11 Thread Jiri Pirko
Thu, Jun 11, 2015 at 05:03:21PM CEST, sfel...@gmail.com wrote: >On Wed, Jun 10, 2015 at 11:16 PM, Jiri Pirko wrote: >> Thu, Jun 11, 2015 at 12:00:47AM CEST, sfel...@gmail.com wrote: >>>On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman wrote: On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote:

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-11 Thread Scott Feldman
On Wed, Jun 10, 2015 at 11:16 PM, Jiri Pirko wrote: > Thu, Jun 11, 2015 at 12:00:47AM CEST, sfel...@gmail.com wrote: >>On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman wrote: >>> On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote: On 6/10/15 2:56 PM, sfel...@gmail.com wrote: > > From:

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-11 Thread David Miller
From: sfel...@gmail.com Date: Wed, 10 Jun 2015 13:56:02 -0700 > From: Scott Feldman > > Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged > port does not support switchdec_port_attr_set op. Don't BUG() if > -EOPNOTSUPP is returned. > > Signed-off-by: Scott Feldman > R

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread Jiri Pirko
Thu, Jun 11, 2015 at 12:00:47AM CEST, sfel...@gmail.com wrote: >On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman wrote: >> On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote: >>> On 6/10/15 2:56 PM, sfel...@gmail.com wrote: From: Scott Feldman Fix a BUG() where CONFIG_NET_SWITC

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman wrote: > On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote: >> On 6/10/15 2:56 PM, sfel...@gmail.com wrote: >>> >>> From: Scott Feldman >>> >>> Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged >>> port does not support swi

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread David Ahern
On 6/10/15 3:47 PM, Scott Feldman wrote: Should that be WARN_ON instead of BUG_ON? I think I had it as WARN when we were working on the initial patches, but we changed it to BUG_ON because we should only get an error here if the driver screwed something up between PREPARE phase and COMMIT phase

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote: > On 6/10/15 2:56 PM, sfel...@gmail.com wrote: >> >> From: Scott Feldman >> >> Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged >> port does not support switchdec_port_attr_set op. Don't BUG() if >> -EOPNOTSUPP is retu

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread David Ahern
On 6/10/15 2:56 PM, sfel...@gmail.com wrote: From: Scott Feldman Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged port does not support switchdec_port_attr_set op. Don't BUG() if -EOPNOTSUPP is returned. Signed-off-by: Scott Feldman Reported-by: Brenden Blanco ---

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 01:56:02PM -0700, sfel...@gmail.com wrote: > From: Scott Feldman > > Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged > port does not support switchdec_port_attr_set op. Don't BUG() if > -EOPNOTSUPP is returned. > > Signed-off-by: Scott Feldman

[PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread sfeldma
From: Scott Feldman Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged port does not support switchdec_port_attr_set op. Don't BUG() if -EOPNOTSUPP is returned. Signed-off-by: Scott Feldman Reported-by: Brenden Blanco --- net/switchdev/switchdev.c |2 +- 1 file ch