From: Hannes Frederic Sowa
Date: Thu, 7 Apr 2016 23:53:35 +0200
> I forgot to add inline to lockdep_sock_is_held, so it generated all
> kinds of build warnings if not build with lockdep support.
>
> Reported-by: kbuild test robot
> Signed-off-by: Hannes Frederic Sowa
Applied, thanks.
On 08.04.2016 01:08, Eric Dumazet wrote:
On Fri, 2016-04-08 at 00:47 +0200, Hannes Frederic Sowa wrote:
I see... hmpf.
Wouldn't it be nicer if I include a helper a la:
#define lockdep_is_held(lock) 1
in lockdep.h in case lockdep is globally not enabled? I do actually have
already another us
On Fri, 2016-04-08 at 00:47 +0200, Hannes Frederic Sowa wrote:
> I see... hmpf.
>
> Wouldn't it be nicer if I include a helper a la:
>
> #define lockdep_is_held(lock) 1
>
> in lockdep.h in case lockdep is globally not enabled? I do actually have
> already another user for this outside of PROV
On 08.04.2016 00:37, Eric Dumazet wrote:
On Thu, 2016-04-07 at 15:30 -0700, Eric Dumazet wrote:
But... this wont solve the compiler error ?
include/net/sock.h: In function 'lockdep_sock_is_held':
include/net/sock.h:1367:2: error: implicit declaration of function
'lockdep_is_held' [-Werror=impl
On Thu, 2016-04-07 at 15:30 -0700, Eric Dumazet wrote:
> But... this wont solve the compiler error ?
>
> include/net/sock.h: In function 'lockdep_sock_is_held':
> include/net/sock.h:1367:2: error: implicit declaration of function
> 'lockdep_is_held' [-Werror=implicit-function-declaration]
> In fi
On Thu, 2016-04-07 at 23:53 +0200, Hannes Frederic Sowa wrote:
> I forgot to add inline to lockdep_sock_is_held, so it generated all
> kinds of build warnings if not build with lockdep support.
>
> Reported-by: kbuild test robot
> Signed-off-by: Hannes Frederic Sowa
> ---
> include/net/sock.h |
I forgot to add inline to lockdep_sock_is_held, so it generated all
kinds of build warnings if not build with lockdep support.
Reported-by: kbuild test robot
Signed-off-by: Hannes Frederic Sowa
---
include/net/sock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/ne
