Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread David Miller
From: Hannes Frederic Sowa Date: Mon, 26 Oct 2015 13:51:37 +0100 > netstamp_needed is toggled for all socket families if they request > timestamping. But some protocols don't need the lower-layer timestamping > code at all. This patch starts disabling it for af-unix. > > E.g. systemd enables tim

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Eric Dumazet
On Tue, 2015-10-27 at 14:44 +0100, Hannes Frederic Sowa wrote: > > On Tue, Oct 27, 2015, at 14:19, Eric Dumazet wrote: > > On Tue, 2015-10-27 at 12:15 +0100, Hannes Frederic Sowa wrote: > > > > > Also counter question: why is the netstamp code protected by a > > > static_key otherwise if not for

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 14:19, Eric Dumazet wrote: > On Tue, 2015-10-27 at 12:15 +0100, Hannes Frederic Sowa wrote: > > > Also counter question: why is the netstamp code protected by a > > static_key otherwise if not for trying to suppress the code path as > > often as possible if not used? ;)

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Eric Dumazet
On Tue, 2015-10-27 at 12:15 +0100, Hannes Frederic Sowa wrote: > Also counter question: why is the netstamp code protected by a > static_key otherwise if not for trying to suppress the code path as > often as possible if not used? ;) Any idea of why timestamping is asked on AF_UNIX in the first p

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Jesper Dangaard Brouer
On Tue, 27 Oct 2015 12:15:16 +0100 Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 12:09, Hannes Frederic Sowa wrote: > > Hi Richard, > > > > On Tue, Oct 27, 2015, at 11:11, Richard Cochran wrote: > > > On Mon, Oct 26, 2015 at 02:32:59PM +0100, Hannes Frederic Sowa wrote: > > > > On Mon

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 12:09, Hannes Frederic Sowa wrote: > Hi Richard, > > On Tue, Oct 27, 2015, at 11:11, Richard Cochran wrote: > > On Mon, Oct 26, 2015 at 02:32:59PM +0100, Hannes Frederic Sowa wrote: > > > On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote: > > > > On Mon, Oct 26, 2015

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Hannes Frederic Sowa
Hi Richard, On Tue, Oct 27, 2015, at 11:11, Richard Cochran wrote: > On Mon, Oct 26, 2015 at 02:32:59PM +0100, Hannes Frederic Sowa wrote: > > On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote: > > > On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > > > > netstamp_needed

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Richard Cochran
On Mon, Oct 26, 2015 at 02:32:59PM +0100, Hannes Frederic Sowa wrote: > On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote: > > On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > > > netstamp_needed is toggled for all socket families if they request > > > timestamping. But s

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-26 Thread Hannes Frederic Sowa
Hello, On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote: > On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > > netstamp_needed is toggled for all socket families if they request > > timestamping. But some protocols don't need the lower-layer timestamping > > code at all.

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-26 Thread Richard Cochran
On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > netstamp_needed is toggled for all socket families if they request > timestamping. But some protocols don't need the lower-layer timestamping > code at all. This patch starts disabling it for af-unix. What problem is this patc

[PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-26 Thread Hannes Frederic Sowa
netstamp_needed is toggled for all socket families if they request timestamping. But some protocols don't need the lower-layer timestamping code at all. This patch starts disabling it for af-unix. E.g. systemd enables timestamping during boot-up on the journald af-unix sockets, thus causing the sy