Re: [PATCH net-next] skbuff: only inherit relevant tx_flags

2017-06-08 Thread Eric Dumazet
On Thu, 2017-06-08 at 11:35 -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > When inheriting tx_flags from one skbuff to another, always apply a > mask to avoid overwriting unrelated other bits in the field. > > The two SKBTX_SHARED_FRAG cases clears all other bits. In practice, > tx_

Re: [PATCH net-next] skbuff: only inherit relevant tx_flags

2017-06-08 Thread Soheil Hassas Yeganeh
On Thu, Jun 8, 2017 at 11:35 AM, Willem de Bruijn wrote: > > From: Willem de Bruijn > > When inheriting tx_flags from one skbuff to another, always apply a > mask to avoid overwriting unrelated other bits in the field. > > The two SKBTX_SHARED_FRAG cases clears all other bits. In practice, > tx_f

[PATCH net-next] skbuff: only inherit relevant tx_flags

2017-06-08 Thread Willem de Bruijn
From: Willem de Bruijn When inheriting tx_flags from one skbuff to another, always apply a mask to avoid overwriting unrelated other bits in the field. The two SKBTX_SHARED_FRAG cases clears all other bits. In practice, tx_flags are zero at this point now. But this is fragile. Timestamp flags ar